Make the rustc respect the `-C codegen-units` flag in incremental mode. #70156

michaelwoerister · 2020-03-19T16:24:49Z

This PR implements (the as of yet unapproved) major change proposal at rust-lang/compiler-team#245. See the description there for background and rationale.

The changes are pretty straightforward and should be easy to rebase if the proposal gets accepted at some point.

r? @nikomatsakis cc @pnkfelix

michaelwoerister · 2020-03-20T13:36:38Z

@bors try @rust-timer queue

rust-timer · 2020-03-20T13:36:39Z

Awaiting bors try build completion

bors · 2020-03-20T13:36:51Z

⌛ Trying commit e898fe8d0591a9cf41a740dc32acb8b57a4b7e37 with merge cb6f9841c429f6f78dad6bae3d61ebe0fd8c37d9...

bors · 2020-03-20T16:33:07Z

☀️ Try build successful - checks-azure
Build commit: cb6f9841c429f6f78dad6bae3d61ebe0fd8c37d9 (cb6f9841c429f6f78dad6bae3d61ebe0fd8c37d9)

rust-timer · 2020-03-20T16:33:09Z

Queued cb6f9841c429f6f78dad6bae3d61ebe0fd8c37d9 with parent f4c675c, future comparison URL.

rust-timer · 2020-03-20T18:43:10Z

Finished benchmarking try commit cb6f9841c429f6f78dad6bae3d61ebe0fd8c37d9, comparison URL.

bjorn3 · 2020-03-20T19:06:50Z

Servo improved a lot, clap regressed a lot. Overall it is positive.

I don't know how much this would affect cg_clif. Cranelift is made to compile one function at a time, so maybe using many cgus will not have as much of an overhead as cg_llvm. If so the reduced granularity of incremental compilation may outweight the benefits of less overhead for cg_clif. Would it make sense to make this configurable on a per backend level? (Preferably in a way that would also make #68349 possible.)

michaelwoerister · 2020-03-23T09:42:11Z

clap doesn't really regress. It's just that that crate explicitly sets its CGU count to 4 which makes incremental compilation ineffective. Removing that line from the Cargo.toml brings things back to normal. The opt build (which does not have an explicit setting for codegen-units) is unaffected.

I'd expect the rules for a cranelift backend to be rather different overall. You could certainly make it use a different default if necessary.

bjorn3 · 2020-03-23T10:21:04Z

You could certainly make it use a different default if necessary.

No, I can't. I can't change rustc_session. I was suggesting to add some way for the codegen backend to tell the partition code what the maximum amount of codegen units is instead of hard coding it in rustc_session..

nikomatsakis · 2020-03-26T21:36:11Z

That seems potentially useful, but I think it's best if we defer until we have a real need -- especially because it's only going to be a small number of crates that explicitly set any value at all, right?

nikomatsakis

Code seems reasonable. One question?

src/librustc_mir/monomorphize/partitioning.rs

nikomatsakis · 2020-03-30T14:40:11Z

OK, r=me once rebased. I'm inclined to go forward and land this, since I don't expect any concerns to be raised on rust-lang/compiler-team#245 and we could always back it out if needed.

Before this commit `-C codegen-units` would just get silently be ignored if `-C incremental` was specified too. After this commit one can control the number of codegen units generated during incremental compilation. The default is rather high at 256, so most crates won't see a difference unless explicitly opting into a lower count.

michaelwoerister · 2020-03-31T15:40:23Z

@bors r=nikomatsakis

bors · 2020-03-31T15:40:24Z

📌 Commit 408e6e3 has been approved by nikomatsakis

michaelwoerister · 2020-03-31T15:43:41Z

I added the relnotes tag since this might negatively affect compile times for crates that explicitly set codegen-units in their Cargo.toml as explained in rust-lang/compiler-team#245. This is easily fixable by adjusting or removing the codegen-units setting.

ehuss · 2020-03-31T15:55:39Z

Would you mind updating the documentation? There is a sentence at https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/codegen-options/index.md#codegen-units that mentions its behavior with incremental that I think should be removed. If there is anything else in the documentation that could be fixed or expanded upon, your expertise would be appreciated!

michaelwoerister · 2020-03-31T16:02:01Z

@bors r-

Good catch, @ehuss! I'll look into it.

michaelwoerister · 2020-04-01T12:54:33Z

I updated the rustc book. I didn't find any other places that needed updating.

@bors r=nikomatsakis

bors · 2020-04-01T12:54:35Z

📌 Commit 98ead3e has been approved by nikomatsakis

bors · 2020-04-01T12:54:36Z

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

nikomatsakis · 2020-04-01T12:56:22Z

Yeah, good catch indeed! Thanks @ehuss

@nikomatsakis

…atsakis Make the rustc respect the `-C codegen-units` flag in incremental mode. This PR implements (the as of yet unapproved) major change proposal at rust-lang/compiler-team#245. See the description there for background and rationale. The changes are pretty straightforward and should be easy to rebase if the proposal gets accepted at some point. r? @nikomatsakis cc @pnkfelix

Centril · 2020-04-02T10:15:34Z

@bors rollup=never

@rust-lang/compiler For future reference, PRs like these should have rollup=never so that they don't mask regressions in a rollup.

Centril · 2020-04-03T17:35:09Z

@bors p=1

bors · 2020-04-03T20:48:59Z

⌛ Testing commit 98ead3e with merge e0657b90bce123af15a105fcac3742948dd4ef93...

Centril · 2020-04-03T20:56:00Z

@bors retry yielding

bors · 2020-04-03T23:50:07Z

⌛ Testing commit 98ead3e with merge 9e55101...

bors · 2020-04-04T02:41:29Z

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 9e55101 to master...

Update default for codegen-units. The default for codegen-units was changed in rust-lang/rust#70156.

Pkgsrc changes: * Remove a couple diffs which are now integrated upstream. * Adjust cargo checksums after upstream upgrades. * Belatedly bump the curl dependency * Unset DESTDIR during the build phase, to work around a mysterious build bug deep in the bowels of llvm. * Bump nearly all bootstraps to 1.43.1. Upstream changes: Version 1.44.0 (2020-06-04) ========================== Language -------- - [You can now use `async/.await` with `#[no_std]` enabled.][69033] - [Added the `unused_braces` lint.][70081] **Syntax-only changes** - [Expansion-driven outline module parsing][69838] ```rust #[cfg(FALSE)] mod foo { mod bar { mod baz; // `foo/bar/baz.rs` doesn't exist, but no error! } } ``` These are still rejected semantically, so you will likely receive an error but these changes can be seen and parsed by macros and conditional compilation. Compiler -------- - [Rustc now respects the `-C codegen-units` flag in incremental mode.][70156] Additionally when in incremental mode rustc defaults to 256 codegen units. - [Refactored `catch_unwind`, to have zero-cost unless unwinding is enabled and a panic is thrown.][67502] - [Added tier 3\* support for the `aarch64-unknown-none` and `aarch64-unknown-none-softfloat` targets.][68334] - [Added tier 3 support for `arm64-apple-tvos` and `x86_64-apple-tvos` targets.][68191] Libraries --------- - [Special cased `vec![]` to map directly to `Vec::new()`.][70632] This allows `vec![]` to be able to be used in `const` contexts. - [`convert::Infallible` now implements `Hash`.][70281] - [`OsString` now implements `DerefMut` and `IndexMut` returning a `&mut OsStr`.][70048] - [Unicode 13 is now supported.][69929] - [`String` now implements `From<&mut str>`.][69661] - [`IoSlice` now implements `Copy`.][69403] - [`Vec<T>` now implements `From<[T; N]>`.][68692] Where `N` is less than 32. - [`proc_macro::LexError` now implements `fmt::Display` and `Error`.][68899] - [`from_le_bytes`, `to_le_bytes`, `from_be_bytes`, `to_be_bytes`, `from_ne_bytes`, and `to_ne_bytes` methods are now `const` for all integer types.][69373] Stabilized APIs --------------- - [`PathBuf::with_capacity`] - [`PathBuf::capacity`] - [`PathBuf::clear`] - [`PathBuf::reserve`] - [`PathBuf::reserve_exact`] - [`PathBuf::shrink_to_fit`] - [`f32::to_int_unchecked`] - [`f64::to_int_unchecked`] - [`Layout::align_to`] - [`Layout::pad_to_align`] - [`Layout::array`] - [`Layout::extend`] Cargo ----- - [Added the `cargo tree` command which will print a tree graph of your dependencies.][cargo/8062] E.g. ``` mdbook v0.3.2 (/Users/src/rust/mdbook) +-- ammonia v3.0.0 | +-- html5ever v0.24.0 | | +-- log v0.4.8 | | | +-- cfg-if v0.1.9 | | +-- mac v0.1.1 | | +-- markup5ever v0.9.0 | | +-- log v0.4.8 (*) | | +-- phf v0.7.24 | | | +-- phf_shared v0.7.24 | | | +-- siphasher v0.2.3 | | | +-- unicase v1.4.2 | | | [build-dependencies] | | | +-- version_check v0.1.5 ... ``` You can also display dependencies on multiple versions of the same crate with `cargo tree -d` (short for `cargo tree --duplicates`). Misc ---- - [Rustdoc now allows you to specify `--crate-version` to have rustdoc include the version in the sidebar.][69494] Compatibility Notes ------------------- - [Rustc now correctly generates static libraries on Windows GNU targets with the `.a` extension, rather than the previous `.lib`.][70937] - [Removed the `-C no_integrated_as` flag from rustc.][70345] - [The `file_name` property in JSON output of macro errors now points the actual source file rather than the previous format of `<NAME macros>`.][70969] **Note:** this may not point a file that actually exists on the user's system. - [The minimum required external LLVM version has been bumped to LLVM 8.][71147] - [`mem::{zeroed, uninitialised}` will now panic when used with types that do not allow zero initialization such as `NonZeroU8`.][66059] This was previously a warning. - [In 1.45.0 (the next release) converting a `f64` to `u32` using the `as` operator has been defined as a saturating operation.][71269] This was previously undefined behaviour, you can use the `{f64, f32}::to_int_unchecked` methods to continue using the current behaviour which may desirable in rare performance sensitive situations. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [dep_graph Avoid allocating a set on when the number reads are small.][69778] - [Replace big JS dict with JSON parsing.][71250] [69373]: rust-lang/rust#69373 [66059]: rust-lang/rust#66059 [68191]: rust-lang/rust#68191 [68899]: rust-lang/rust#68899 [71147]: rust-lang/rust#71147 [71250]: rust-lang/rust#71250 [70937]: rust-lang/rust#70937 [70969]: rust-lang/rust#70969 [70632]: rust-lang/rust#70632 [70281]: rust-lang/rust#70281 [70345]: rust-lang/rust#70345 [70048]: rust-lang/rust#70048 [70081]: rust-lang/rust#70081 [70156]: rust-lang/rust#70156 [71269]: rust-lang/rust#71269 [69838]: rust-lang/rust#69838 [69929]: rust-lang/rust#69929 [69661]: rust-lang/rust#69661 [69778]: rust-lang/rust#69778 [69494]: rust-lang/rust#69494 [69403]: rust-lang/rust#69403 [69033]: rust-lang/rust#69033 [68692]: rust-lang/rust#68692 [68334]: rust-lang/rust#68334 [67502]: rust-lang/rust#67502 [cargo/8062]: rust-lang/cargo#8062 [`PathBuf::with_capacity`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.with_capacity [`PathBuf::capacity`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.capacity [`PathBuf::clear`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.clear [`PathBuf::reserve`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.reserve [`PathBuf::reserve_exact`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.reserve_exact [`PathBuf::shrink_to_fit`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.shrink_to_fit [`f32::to_int_unchecked`]: https://doc.rust-lang.org/std/primitive.f32.html#method.to_int_unchecked [`f64::to_int_unchecked`]: https://doc.rust-lang.org/std/primitive.f64.html#method.to_int_unchecked [`Layout::align_to`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.align_to [`Layout::pad_to_align`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.pad_to_align [`Layout::array`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.array [`Layout::extend`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.extend

Version 1.44.0 (2020-06-04) ========================== Language -------- - [You can now use `async/.await` with `#[no_std]` enabled.][69033] - [Added the `unused_braces` lint.][70081] **Syntax-only changes** - [Expansion-driven outline module parsing][69838] ```rust #[cfg(FALSE)] mod foo { mod bar { mod baz; // `foo/bar/baz.rs` doesn't exist, but no error! } } ``` These are still rejected semantically, so you will likely receive an error but these changes can be seen and parsed by macros and conditional compilation. Compiler -------- - [Rustc now respects the `-C codegen-units` flag in incremental mode.][70156] Additionally when in incremental mode rustc defaults to 256 codegen units. - [Refactored `catch_unwind` to have zero-cost, unless unwinding is enabled and a panic is thrown.][67502] - [Added tier 3\* support for the `aarch64-unknown-none` and `aarch64-unknown-none-softfloat` targets.][68334] - [Added tier 3 support for `arm64-apple-tvos` and `x86_64-apple-tvos` targets.][68191] Libraries --------- - [Special cased `vec![]` to map directly to `Vec::new()`.][70632] This allows `vec![]` to be able to be used in `const` contexts. - [`convert::Infallible` now implements `Hash`.][70281] - [`OsString` now implements `DerefMut` and `IndexMut` returning a `&mut OsStr`.][70048] - [Unicode 13 is now supported.][69929] - [`String` now implements `From<&mut str>`.][69661] - [`IoSlice` now implements `Copy`.][69403] - [`Vec<T>` now implements `From<[T; N]>`.][68692] Where `N` is at most 32. - [`proc_macro::LexError` now implements `fmt::Display` and `Error`.][68899] - [`from_le_bytes`, `to_le_bytes`, `from_be_bytes`, `to_be_bytes`, `from_ne_bytes`, and `to_ne_bytes` methods are now `const` for all integer types.][69373] Stabilized APIs --------------- - [`PathBuf::with_capacity`] - [`PathBuf::capacity`] - [`PathBuf::clear`] - [`PathBuf::reserve`] - [`PathBuf::reserve_exact`] - [`PathBuf::shrink_to_fit`] - [`f32::to_int_unchecked`] - [`f64::to_int_unchecked`] - [`Layout::align_to`] - [`Layout::pad_to_align`] - [`Layout::array`] - [`Layout::extend`] Cargo ----- - [Added the `cargo tree` command which will print a tree graph of your dependencies.][cargo/8062] E.g. ``` mdbook v0.3.2 (/Users/src/rust/mdbook) ├── ammonia v3.0.0 │ ├── html5ever v0.24.0 │ │ ├── log v0.4.8 │ │ │ └── cfg-if v0.1.9 │ │ ├── mac v0.1.1 │ │ └── markup5ever v0.9.0 │ │ ├── log v0.4.8 (*) │ │ ├── phf v0.7.24 │ │ │ └── phf_shared v0.7.24 │ │ │ ├── siphasher v0.2.3 │ │ │ └── unicase v1.4.2 │ │ │ [build-dependencies] │ │ │ └── version_check v0.1.5 ... ``` You can also display dependencies on multiple versions of the same crate with `cargo tree -d` (short for `cargo tree --duplicates`). Misc ---- - [Rustdoc now allows you to specify `--crate-version` to have rustdoc include the version in the sidebar.][69494] Compatibility Notes ------------------- - [Rustc now correctly generates static libraries on Windows GNU targets with the `.a` extension, rather than the previous `.lib`.][70937] - [Removed the `-C no_integrated_as` flag from rustc.][70345] - [The `file_name` property in JSON output of macro errors now points the actual source file rather than the previous format of `<NAME macros>`.][70969] **Note:** this may not point to a file that actually exists on the user's system. - [The minimum required external LLVM version has been bumped to LLVM 8.][71147] - [`mem::{zeroed, uninitialised}` will now panic when used with types that do not allow zero initialization such as `NonZeroU8`.][66059] This was previously a warning. - [In 1.45.0 (the next release) converting a `f64` to `u32` using the `as` operator has been defined as a saturating operation.][71269] This was previously undefined behaviour, but you can use the `{f64, f32}::to_int_unchecked` methods to continue using the current behaviour, which may be desirable in rare performance sensitive situations. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [dep_graph Avoid allocating a set on when the number reads are small.][69778] - [Replace big JS dict with JSON parsing.][71250] [69373]: rust-lang/rust#69373 [66059]: rust-lang/rust#66059 [68191]: rust-lang/rust#68191 [68899]: rust-lang/rust#68899 [71147]: rust-lang/rust#71147 [71250]: rust-lang/rust#71250 [70937]: rust-lang/rust#70937 [70969]: rust-lang/rust#70969 [70632]: rust-lang/rust#70632 [70281]: rust-lang/rust#70281 [70345]: rust-lang/rust#70345 [70048]: rust-lang/rust#70048 [70081]: rust-lang/rust#70081 [70156]: rust-lang/rust#70156 [71269]: rust-lang/rust#71269 [69838]: rust-lang/rust#69838 [69929]: rust-lang/rust#69929 [69661]: rust-lang/rust#69661 [69778]: rust-lang/rust#69778 [69494]: rust-lang/rust#69494 [69403]: rust-lang/rust#69403 [69033]: rust-lang/rust#69033 [68692]: rust-lang/rust#68692 [68334]: rust-lang/rust#68334 [67502]: rust-lang/rust#67502 [cargo/8062]: rust-lang/cargo#8062 [`PathBuf::with_capacity`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.with_capacity [`PathBuf::capacity`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.capacity [`PathBuf::clear`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.clear [`PathBuf::reserve`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.reserve [`PathBuf::reserve_exact`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.reserve_exact [`PathBuf::shrink_to_fit`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.shrink_to_fit [`f32::to_int_unchecked`]: https://doc.rust-lang.org/std/primitive.f32.html#method.to_int_unchecked [`f64::to_int_unchecked`]: https://doc.rust-lang.org/std/primitive.f64.html#method.to_int_unchecked [`Layout::align_to`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.align_to [`Layout::pad_to_align`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.pad_to_align [`Layout::array`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.array [`Layout::extend`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.extend

Pkgsrc changes: * Remove the clutter caused by the cross-compile setup from Makefile (Now consigned to my own private cross.mk file.) * Remove a couple of patches which are now integrated upstream. * Minor adjustments to a couple of other patches. * Adjust cargo checksums after upstream upgrades. * Belatedly bump the curl dependency * If doing a "dist" build, unset DESTDIR during the build phase, to work around a mysterious build bug deep in the bowels of llvm, causing llvm tools to be installed to a directory unexpecetd by the rest of the rust build, ref. rust-lang/rust#73132 A "dist" build is not expected to be followed by an "install". * Bump nearly all bootstraps to 1.43.1; NetBSD earmv7hf bootstrap bumped to 1.44.0, as that one now finally builds and works. Upstream changes: Version 1.44.0 (2020-06-04) ========================== Language -------- - [You can now use `async/.await` with `#[no_std]` enabled.][69033] - [Added the `unused_braces` lint.][70081] **Syntax-only changes** - [Expansion-driven outline module parsing][69838] ```rust #[cfg(FALSE)] mod foo { mod bar { mod baz; // `foo/bar/baz.rs` doesn't exist, but no error! } } ``` These are still rejected semantically, so you will likely receive an error but these changes can be seen and parsed by macros and conditional compilation. Compiler -------- - [Rustc now respects the `-C codegen-units` flag in incremental mode.][70156] Additionally when in incremental mode rustc defaults to 256 codegen units. - [Refactored `catch_unwind`, to have zero-cost unless unwinding is enabled and a panic is thrown.][67502] - [Added tier 3\* support for the `aarch64-unknown-none` and `aarch64-unknown-none-softfloat` targets.][68334] - [Added tier 3 support for `arm64-apple-tvos` and `x86_64-apple-tvos` targets.][68191] Libraries --------- - [Special cased `vec![]` to map directly to `Vec::new()`.][70632] This allows `vec![]` to be able to be used in `const` contexts. - [`convert::Infallible` now implements `Hash`.][70281] - [`OsString` now implements `DerefMut` and `IndexMut` returning a `&mut OsStr`.][70048] - [Unicode 13 is now supported.][69929] - [`String` now implements `From<&mut str>`.][69661] - [`IoSlice` now implements `Copy`.][69403] - [`Vec<T>` now implements `From<[T; N]>`.][68692] Where `N` is less than 32. - [`proc_macro::LexError` now implements `fmt::Display` and `Error`.][68899] - [`from_le_bytes`, `to_le_bytes`, `from_be_bytes`, `to_be_bytes`, `from_ne_bytes`, and `to_ne_bytes` methods are now `const` for all integer types.][69373] Stabilized APIs --------------- - [`PathBuf::with_capacity`] - [`PathBuf::capacity`] - [`PathBuf::clear`] - [`PathBuf::reserve`] - [`PathBuf::reserve_exact`] - [`PathBuf::shrink_to_fit`] - [`f32::to_int_unchecked`] - [`f64::to_int_unchecked`] - [`Layout::align_to`] - [`Layout::pad_to_align`] - [`Layout::array`] - [`Layout::extend`] Cargo ----- - [Added the `cargo tree` command which will print a tree graph of your dependencies.][cargo/8062] E.g. ``` mdbook v0.3.2 (/Users/src/rust/mdbook) +-- ammonia v3.0.0 | +-- html5ever v0.24.0 | | +-- log v0.4.8 | | | +-- cfg-if v0.1.9 | | +-- mac v0.1.1 | | +-- markup5ever v0.9.0 | | +-- log v0.4.8 (*) | | +-- phf v0.7.24 | | | +-- phf_shared v0.7.24 | | | +-- siphasher v0.2.3 | | | +-- unicase v1.4.2 | | | [build-dependencies] | | | +-- version_check v0.1.5 ... ``` You can also display dependencies on multiple versions of the same crate with `cargo tree -d` (short for `cargo tree --duplicates`). Misc ---- - [Rustdoc now allows you to specify `--crate-version` to have rustdoc include the version in the sidebar.][69494] Compatibility Notes ------------------- - [Rustc now correctly generates static libraries on Windows GNU targets with the `.a` extension, rather than the previous `.lib`.][70937] - [Removed the `-C no_integrated_as` flag from rustc.][70345] - [The `file_name` property in JSON output of macro errors now points the actual source file rather than the previous format of `<NAME macros>`.][70969] **Note:** this may not point a file that actually exists on the user's system. - [The minimum required external LLVM version has been bumped to LLVM 8.][71147] - [`mem::{zeroed, uninitialised}` will now panic when used with types that do not allow zero initialization such as `NonZeroU8`.][66059] This was previously a warning. - [In 1.45.0 (the next release) converting a `f64` to `u32` using the `as` operator has been defined as a saturating operation.][71269] This was previously undefined behaviour, you can use the `{f64, f32}::to_int_unchecked` methods to continue using the current behaviour which may desirable in rare performance sensitive situations. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [dep_graph Avoid allocating a set on when the number reads are small.][69778] - [Replace big JS dict with JSON parsing.][71250] [69373]: rust-lang/rust#69373 [66059]: rust-lang/rust#66059 [68191]: rust-lang/rust#68191 [68899]: rust-lang/rust#68899 [71147]: rust-lang/rust#71147 [71250]: rust-lang/rust#71250 [70937]: rust-lang/rust#70937 [70969]: rust-lang/rust#70969 [70632]: rust-lang/rust#70632 [70281]: rust-lang/rust#70281 [70345]: rust-lang/rust#70345 [70048]: rust-lang/rust#70048 [70081]: rust-lang/rust#70081 [70156]: rust-lang/rust#70156 [71269]: rust-lang/rust#71269 [69838]: rust-lang/rust#69838 [69929]: rust-lang/rust#69929 [69661]: rust-lang/rust#69661 [69778]: rust-lang/rust#69778 [69494]: rust-lang/rust#69494 [69403]: rust-lang/rust#69403 [69033]: rust-lang/rust#69033 [68692]: rust-lang/rust#68692 [68334]: rust-lang/rust#68334 [67502]: rust-lang/rust#67502 [cargo/8062]: rust-lang/cargo#8062 [`PathBuf::with_capacity`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.with_capacity [`PathBuf::capacity`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.capacity [`PathBuf::clear`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.clear [`PathBuf::reserve`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.reserve [`PathBuf::reserve_exact`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.reserve_exact [`PathBuf::shrink_to_fit`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.shrink_to_fit [`f32::to_int_unchecked`]: https://doc.rust-lang.org/std/primitive.f32.html#method.to_int_unchecked [`f64::to_int_unchecked`]: https://doc.rust-lang.org/std/primitive.f64.html#method.to_int_unchecked [`Layout::align_to`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.align_to [`Layout::pad_to_align`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.pad_to_align [`Layout::array`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.array [`Layout::extend`]: https://doc.rust-lang.org/std/alloc/struct.Layout.html#method.extend

rust-highfive assigned nikomatsakis Mar 19, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2020

nikomatsakis approved these changes Mar 30, 2020

View reviewed changes

src/librustc_mir/monomorphize/partitioning.rs Show resolved Hide resolved

michaelwoerister added 2 commits March 31, 2020 16:11

Add a test case for incremental + codegen-units interaction.

408e6e3

michaelwoerister force-pushed the incr-cgus branch from e898fe8 to 408e6e3 Compare March 31, 2020 14:24

michaelwoerister added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 31, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2020

Update -Ccodegen-units docs wrt incr. comp. in rustc book.

98ead3e

michaelwoerister mentioned this pull request Apr 1, 2020

[experiment] Make incremental compilation respect the -Ccodegen-units flag. #67834

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2020

Dylan-DPC-zz mentioned this pull request Apr 1, 2020

Rollup of 3 pull requests #70676

Closed

Centril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 2, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2020

bors merged commit 9e55101 into rust-lang:master Apr 4, 2020

This was referenced Apr 4, 2020

Allocate some query results on an arena #70161

Merged

A big options clean-up #70729

Merged

eddyb mentioned this pull request Apr 4, 2020

A big performance regression in benchmarks #70785

Closed

mati865 mentioned this pull request Apr 8, 2020

Fix performance regression in debuginfo file_metadata. #70803

Merged

ehuss mentioned this pull request Apr 11, 2020

Update default for codegen-units. rust-lang/cargo#8096

Merged

bors added a commit to rust-lang/cargo that referenced this pull request Apr 11, 2020

Auto merge of #8096 - ehuss:codegen-units-default, r=Eh2406

12d6e84

Update default for codegen-units. The default for codegen-units was changed in rust-lang/rust#70156.

jonas-schievink added this to the 1.44 milestone Apr 20, 2020

jonas-schievink mentioned this pull request Apr 20, 2020

codegen-units=1 not honored #65996

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the rustc respect the `-C codegen-units` flag in incremental mode. #70156

Make the rustc respect the `-C codegen-units` flag in incremental mode. #70156

michaelwoerister commented Mar 19, 2020

michaelwoerister commented Mar 20, 2020

rust-timer commented Mar 20, 2020

bors commented Mar 20, 2020

bors commented Mar 20, 2020

rust-timer commented Mar 20, 2020

rust-timer commented Mar 20, 2020

bjorn3 commented Mar 20, 2020

michaelwoerister commented Mar 23, 2020

bjorn3 commented Mar 23, 2020

nikomatsakis commented Mar 26, 2020

nikomatsakis left a comment

nikomatsakis commented Mar 30, 2020

michaelwoerister commented Mar 31, 2020

bors commented Mar 31, 2020

michaelwoerister commented Mar 31, 2020 •

edited

Loading

ehuss commented Mar 31, 2020

michaelwoerister commented Mar 31, 2020

michaelwoerister commented Apr 1, 2020

bors commented Apr 1, 2020

bors commented Apr 1, 2020

nikomatsakis commented Apr 1, 2020

Centril commented Apr 2, 2020

Centril commented Apr 3, 2020

bors commented Apr 3, 2020

Centril commented Apr 3, 2020

bors commented Apr 3, 2020

bors commented Apr 4, 2020

Make the rustc respect the -C codegen-units flag in incremental mode. #70156

Make the rustc respect the -C codegen-units flag in incremental mode. #70156

Conversation

michaelwoerister commented Mar 19, 2020

michaelwoerister commented Mar 20, 2020

rust-timer commented Mar 20, 2020

bors commented Mar 20, 2020

bors commented Mar 20, 2020

rust-timer commented Mar 20, 2020

rust-timer commented Mar 20, 2020

bjorn3 commented Mar 20, 2020

michaelwoerister commented Mar 23, 2020

bjorn3 commented Mar 23, 2020

nikomatsakis commented Mar 26, 2020

nikomatsakis left a comment

Choose a reason for hiding this comment

nikomatsakis commented Mar 30, 2020

michaelwoerister commented Mar 31, 2020

bors commented Mar 31, 2020

michaelwoerister commented Mar 31, 2020 • edited Loading

ehuss commented Mar 31, 2020

michaelwoerister commented Mar 31, 2020

michaelwoerister commented Apr 1, 2020

bors commented Apr 1, 2020

bors commented Apr 1, 2020

nikomatsakis commented Apr 1, 2020

Centril commented Apr 2, 2020

Centril commented Apr 3, 2020

bors commented Apr 3, 2020

Centril commented Apr 3, 2020

bors commented Apr 3, 2020

bors commented Apr 4, 2020

Make the rustc respect the `-C codegen-units` flag in incremental mode. #70156

Make the rustc respect the `-C codegen-units` flag in incremental mode. #70156

michaelwoerister commented Mar 31, 2020 •

edited

Loading