-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liberate rustc_ast_lowering
from rustc
#70204
Conversation
74cf684
to
5746fd4
Compare
This comment has been minimized.
This comment has been minimized.
5746fd4
to
40cec78
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 40cec78 with merge f60543b065b8eff6ea6ea5d5a66f80541574b97e... |
r=me if perf is fine |
☀️ Try build successful - checks-azure |
Queued f60543b065b8eff6ea6ea5d5a66f80541574b97e with parent 1902d1e, future comparison URL. |
Finished benchmarking try commit f60543b065b8eff6ea6ea5d5a66f80541574b97e, comparison URL. |
That's an unexpected perf result :/ @bors r+ |
📌 Commit 40cec78 has been approved by |
@bors rollup=never p=1 (perf) |
☀️ Test successful - checks-azure |
The whole point of this PR is the very last commit, in which we remove
rustc
as one ofrustc_ast_lowering
's dependencies, thereby improving./x.py
parallelism and working towards #65031.Noteworthy:
rustc::arena
we move logic intoarena
, in particulardeclare_arena!
. This is then used inrustc_ast_lowering
so that lowering has its own separate arena.rustc_session::lint
cause its used both inrustc_lint
andrustc_ast_lowering
, and this is their common dependency.rustc_session::CrateDisambiguator
is moved intorustc_ast
so thatrustc::hir::map::definitions
can be moved intorustc_hir
, so thatrustc_ast_lowering
can stop referring torustc::hir
.r? @Zoxc