Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #70222

Merged
merged 35 commits into from
Mar 21, 2020
Merged

Rollup of 6 pull requests #70222

merged 35 commits into from
Mar 21, 2020

Commits on Mar 16, 2020

  1. Configuration menu
    Copy the full SHA
    0bf5cae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc82376 View commit details
    Browse the repository at this point in the history
  3. Inline QueryAccessor::query.

    cjgillot committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    cf238fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1249032 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b089433 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    486a082 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a0f57e2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fa02dca View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a18aa81 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d125bbb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fa0794d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5dc7c2e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7d84f4f View commit details
    Browse the repository at this point in the history
  14. Simplify type aliases.

    cjgillot committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    7309b3c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3abd475 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    5557407 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Make stuff private.

    cjgillot committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    8aa1328 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Configuration menu
    Copy the full SHA
    f8178c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82920f3 View commit details
    Browse the repository at this point in the history
  3. Update test

    Zoxc committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d641ad0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6cb5846 View commit details
    Browse the repository at this point in the history
  5. fix FIXME comment

    Co-Authored-By: varkor <github@varkor.com>
    lcnr and varkor committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    17c94c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Fix abort-on-eprintln during process shutdown

    This commit fixes an issue where if `eprintln!` is used in a TLS
    destructor it can accidentally cause the process to abort. TLS
    destructors are executed after `main` returns on the main thread, and at
    this point we've also deinitialized global `Lazy` values like those
    which store the `Stderr` and `Stdout` internals. This means that despite
    handling TLS not being accessible in `eprintln!`, we will fail due to
    not being able to call `stderr()`. This means that we'll double-panic
    quickly because panicking also attempt to write to stderr.
    
    The fix here is to reimplement the global stderr handle to avoid the
    need for destruction. This avoids the need for `Lazy` as well as the
    hidden panic inside of the `stderr` function.
    
    Overall this should improve the robustness of printing errors and/or
    panics in weird situations, since the `stderr` accessor should be
    infallible in more situations.
    alexcrichton committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    5edaa7e View commit details
    Browse the repository at this point in the history
  2. fix layout_test visitor name

    RalfJung committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    0296d49 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55c2cf2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d9f60bc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c62e36b View commit details
    Browse the repository at this point in the history
  6. fmt

    RalfJung committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    7b49678 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Configuration menu
    Copy the full SHA
    e548df7 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#69497 - Zoxc:ast-fragment-error, r=petroche…

    …nkov
    
    Don't unwind when hitting the macro expansion recursion limit
    
    This removes one use of `FatalError.raise()`.
    
    r? @petrochenkov
    Dylan-DPC committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    a6596f2 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#69901 - RalfJung:rustc_layout, r=eddyb

    add #[rustc_layout(debug)]
    
    @eddyb recently told me about the `#[rustc_layout]` attribute, and I think it would be very useful if it could be used to print all the layout information Rust has about a type. When working with layouts (e.g. in Miri), it is often not clear how certain surface language features get represented internally. I have some awful hacks locally to be able to dump this debug information; with this attribute I could get it on the playground which is so much better. :)
    Dylan-DPC committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    fd3f917 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#69910 - cjgillot:polym, r=Zoxc

    Avoid query type in generics
    
    There are at the moment roughly 170 queries in librustc.
    The way ty::query is structured, a lot of code is duplicated for each query.
    I suspect this to be responsible for a part of librustc'c compile time.
    
    This PR reduces the amount of code generic on the query,
    replacing it by code generic on the key-value types.
    
    This is split out of rust-lang#69808,
    and should not contain the perf regression.
    
    cc rust-lang#65031
    Dylan-DPC committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    8deeac1 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#69955 - alexcrichton:stderr-infallible, r=s…

    …fackler
    
    Fix abort-on-eprintln during process shutdown
    
    This commit fixes an issue where if `eprintln!` is used in a TLS
    destructor it can accidentally cause the process to abort. TLS
    destructors are executed after `main` returns on the main thread, and at
    this point we've also deinitialized global `Lazy` values like those
    which store the `Stderr` and `Stdout` internals. This means that despite
    handling TLS not being accessible in `eprintln!`, we will fail due to
    not being able to call `stderr()`. This means that we'll double-panic
    quickly because panicking also attempt to write to stderr.
    
    The fix here is to reimplement the global stderr handle to avoid the
    need for destruction. This avoids the need for `Lazy` as well as the
    hidden panic inside of the `stderr` function.
    
    Overall this should improve the robustness of printing errors and/or
    panics in weird situations, since the `stderr` accessor should be
    infallible in more situations.
    Dylan-DPC committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    276b54e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#70032 - lcnr:issue69970, r=varkor

    put type params in front of const params in generics_of
    
    fixes rust-lang#69970
    
    r? @varkor
    Dylan-DPC committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    266801d View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#70119 - eddyb:typeck-tables-local-def-id, r…

    …=petrochenkov
    
    rustc: use LocalDefId instead of DefId in TypeckTables.
    
    The logic in `TypeckTables`' implementation of `HashStable`, which created `DefId`s by combining a `CrateNum` from a `DefId` and a `DefIndex` from a `LocalDefId`, bothered me a bit.
    
    I don't know how much this matters, but it works so might as well submit it.
    Dylan-DPC committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    f1ab750 View commit details
    Browse the repository at this point in the history