resolve: Remove rustc_attrs as a standalone feature gate
#70364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it only gates specific built-in attributes
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit 1fa6be0 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 25, 2020
resolve: Remove `rustc_attrs` as a standalone feature gate Now it only gates specific built-in attributes. So if you want to make a rustc attribute, make it a built-in (this was already the case in practice for some time).
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 25, 2020
resolve: Remove `rustc_attrs` as a standalone feature gate Now it only gates specific built-in attributes. So if you want to make a rustc attribute, make it a built-in (this was already the case in practice for some time).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#70331 (Increase verbosity when using update syntax with private fields) - rust-lang#70349 (move `hir_id_validation` to `rustc_passes` + simplify `hir::map` code) - rust-lang#70361 (Update backtrace crate to 0.3.46) - rust-lang#70364 (resolve: Remove `rustc_attrs` as a standalone feature gate) - rust-lang#70369 (Fix smaller issues with invalid placeholder type errors) - rust-lang#70373 (normalize some imports & prefer direct ones) - rust-lang#70376 (Add test for rust-lang#66312) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it only gates specific built-in attributes.
So if you want to make a rustc attribute, make it a built-in (this was already the case in practice for some time).