Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for raw strings (#60762) #70522

Merged
merged 7 commits into from
Apr 1, 2020
Merged

Improve error messages for raw strings (#60762) #70522

merged 7 commits into from
Apr 1, 2020

Commits on Mar 28, 2020

  1. Move raw string tests into the raw directory

    @rcoh
    rcoh committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    840a576 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. Improve error messages for raw strings (rust-lang#60762) 

    This diff improves error messages around raw strings in a few ways:
- Catch extra trailing `#` in the parser. This can't be handled in the lexer because we could be in a macro that actually expects another # (see test)
- Refactor & unify error handling in the lexer between ByteStrings and RawByteStrings
- Detect potentially intended terminators (longest sequence of "#*" is suggested)
    @rcoh
    rcoh committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    629e97a View commit details
    Browse the repository at this point in the history

  2. Cleanup error messages, improve docstrings

    @rcoh
    rcoh committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    c15f86b View commit details
    Browse the repository at this point in the history

  3. More raw string tests

    @rcoh
    rcoh committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    82b2989 View commit details
    Browse the repository at this point in the history

  4. Cleanup match expression

    @rcoh
    rcoh committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    bceab25 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Clean up redudant conditions and match exprs

    @rcoh
    rcoh committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    20e2190 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Fix tests to handle debug_assert

    @rcoh
    rcoh committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    55a5eea View commit details
    Browse the repository at this point in the history