-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #70581
Rollup of 4 pull requests #70581
Commits on Mar 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 840a576 - Browse repository at this point
Copy the full SHA 840a576View commit details
Commits on Mar 29, 2020
-
Improve error messages for raw strings (rust-lang#60762)
This diff improves error messages around raw strings in a few ways: - Catch extra trailing `#` in the parser. This can't be handled in the lexer because we could be in a macro that actually expects another # (see test) - Refactor & unify error handling in the lexer between ByteStrings and RawByteStrings - Detect potentially intended terminators (longest sequence of "#*" is suggested)
Configuration menu - View commit details
-
Copy full SHA for 629e97a - Browse repository at this point
Copy the full SHA 629e97aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c15f86b - Browse repository at this point
Copy the full SHA c15f86bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82b2989 - Browse repository at this point
Copy the full SHA 82b2989View commit details -
Configuration menu - View commit details
-
Copy full SHA for bceab25 - Browse repository at this point
Copy the full SHA bceab25View commit details
Commits on Mar 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9f86d28 - Browse repository at this point
Copy the full SHA 9f86d28View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc00b16 - Browse repository at this point
Copy the full SHA bc00b16View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6f71f0 - Browse repository at this point
Copy the full SHA d6f71f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20e2190 - Browse repository at this point
Copy the full SHA 20e2190View commit details -
Rollup merge of rust-lang#69458 - Luro02:master, r=GuillaumeGomez,oll…
…ie27 improve folder name for persistent doc tests This partially fixes rust-lang#69411 by using the entire path as folder name, but I do not know how to deal with the proc-macro problem, where a doc test is forwarded to multiple generated functions, which have the same line for the doc test (origin). For example ```rust #[derive(ShortHand)] pub struct ExtXMedia { /// The [`MediaType`] associated with this tag. /// /// # Example /// -> /// ``` <- this line is given to `run_test` /// # use hls_m3u8::tags::ExtXMedia; /// use hls_m3u8::types::MediaType; /// /// let mut media = ExtXMedia::new(MediaType::Audio, "ag1", "english audio channel"); /// /// media.set_media_type(MediaType::Video); /// /// assert_eq!(media.media_type(), MediaType::Video); /// ``` /// /// # Note /// /// This attribute is required. #[shorthand(enable(copy))] media_type: MediaType, // the rest of the fields are omitted } ``` and my proc macro generates ```rust #[allow(dead_code)] impl ExtXMedia { /// The [`MediaType`] associated with this tag. /// /// # Example /// /// ``` /// # use hls_m3u8::tags::ExtXMedia; /// use hls_m3u8::types::MediaType; /// /// let mut media = ExtXMedia::new(MediaType::Audio, "ag1", "english audio channel"); /// /// media.set_media_type(MediaType::Video); /// /// assert_eq!(media.media_type(), MediaType::Video); /// ``` /// /// # Note /// /// This attribute is required. #[inline(always)] #[must_use] pub fn media_type(&self) -> MediaType { struct _AssertCopy where MediaType: ::std::marker::Copy; self.media_type } /// The [`MediaType`] associated with this tag. /// /// # Example /// /// ``` /// # use hls_m3u8::tags::ExtXMedia; /// use hls_m3u8::types::MediaType; /// /// let mut media = ExtXMedia::new(MediaType::Audio, "ag1", "english audio channel"); /// /// media.set_media_type(MediaType::Video); /// /// assert_eq!(media.media_type(), MediaType::Video); /// ``` /// /// # Note /// /// This attribute is required. #[inline(always)] pub fn set_media_type<VALUE: ::std::convert::Into<MediaType>>( &mut self, value: VALUE, ) -> &mut Self { self.media_type = value.into(); self } } ``` rustdoc then executes both tests with the same line (the line from the example above the field -> 2 different tests have the same name). We need a way to differentiate between the two tests generated by the proc-macro, so that they do not cause threading issues.
Configuration menu - View commit details
-
Copy full SHA for b731964 - Browse repository at this point
Copy the full SHA b731964View commit details -
Rollup merge of rust-lang#70522 - rcoh:60762-raw-string-errors, r=pet…
…rochenkov Improve error messages for raw strings (rust-lang#60762) This diff improves error messages around raw strings in a few ways: - Catch extra trailing `#` in the parser. This can't be handled in the lexer because we could be in a macro that actually expects another # (see test) - Refactor & unify error handling in the lexer between ByteStrings and RawByteStrings - Detect potentially intended terminators (longest sequence of "#*" is suggested) Fixes rust-lang#60762 cc @estebank who reviewed the original (abandoned) PR for the same ticket. r? @Centril
Configuration menu - View commit details
-
Copy full SHA for 5bb5d11 - Browse repository at this point
Copy the full SHA 5bb5d11View commit details -
Rollup merge of rust-lang#70555 - Centril:fix-70549, r=petrochenkov
resolve, `try_resolve_as_non_binding`: use `delay_span_bug` due to parser recovery Fixes rust-lang#70549 r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for 52ddd32 - Browse repository at this point
Copy the full SHA 52ddd32View commit details -
Rollup merge of rust-lang#70561 - tshepang:obsolete-comment, r=petroc…
…henkov remove obsolete comment Made obsolete by b5e35b1
Configuration menu - View commit details
-
Copy full SHA for 13f6f8a - Browse repository at this point
Copy the full SHA 13f6f8aView commit details