Add missing -lmsvcrt on mingw after -lpthread

[Amanieu]

Fixes #70316

[rust-highfive]

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

[varkor]

@bors r+ rollup

[mati865]

Why not move

rust/src/librustc_codegen_ssa/back/link.rs

Lines 559 to 561 in 2113659

	if let Some(args) = sess.target.target.options.late_link_args.get(&flavor) {
	cmd.args(args);
	}

below

rust/src/librustc_codegen_ssa/back/link.rs

Lines 562 to 570 in 2113659

	if any_dynamic_crate {
	if let Some(args) = sess.target.target.options.late_link_args_dynamic.get(&flavor) {
	cmd.args(args);
	}
	} else {
	if let Some(args) = sess.target.target.options.late_link_args_static.get(&flavor) {
	cmd.args(args);
	}
	}

instead?

late_link_args contain only "CRT" libraries that have no further dependencies:

rust/src/librustc_target/spec/windows_base.rs

Lines 22 to 40 in 2113659

	late_link_args.insert(
	LinkerFlavor::Gcc,
	vec![
	"-lmingwex".to_string(),
	"-lmingw32".to_string(),
	"-lmsvcrt".to_string(),
	// mingw's msvcrt is a weird hybrid import library and static library.
	// And it seems that the linker fails to use import symbols from msvcrt
	// that are required from functions in msvcrt in certain cases. For example
	// `_fmode` that is used by an implementation of `__p__fmode` in x86_64.
	// Listing the library twice seems to fix that, and seems to also be done
	// by mingw's gcc (Though not sure if it's done on purpose, or by mistake).
	//
	// See https://github.com/rust-lang/rust/pull/47483
	"-lmsvcrt".to_string(),
	"-luser32".to_string(),
	"-lkernel32".to_string(),
	],
	);

[Amanieu]

It's not that simple: the mingw* libraries depend on libgcc.

[mati865]

Bummer, I had thought only winpthreads depend on GCC libs.

[pietroalbini]

@bors r=varkor rollup

Somehow bors missed the approval.

[bors]

📌 Commit 1ae3b50 has been approved by varkor