Rollup of 6 pull requests #70653

Centril · 2020-04-01T12:32:23Z

Successful merges:

Add -Z dump-mir-dataflow flag for dumping dataflow results visualization #70511 (Add -Z dump-mir-dataflow flag for dumping dataflow results visualization)
Improve error messages for raw strings (#60762) #70522 (Improve error messages for raw strings (error for too many trailing #s in raw string literals could be improved #60762))
Add can_unwind field to FnAbi #70547 (Add can_unwind field to FnAbi)
Ensure LLVM is in the link path for "fulldeps" tests #70591 (Ensure LLVM is in the link path for "fulldeps" tests)
Use place directly its copy #70627 (Use place directly its copy)
Add git repo address to unstable book #70652 (Add git repo address to unstable book)

Failed merges:

Remove some reexports in rustc_middle #70634 (Remove some reexports in rustc_middle)

This diff improves error messages around raw strings in a few ways: - Catch extra trailing `#` in the parser. This can't be handled in the lexer because we could be in a macro that actually expects another # (see test) - Refactor & unify error handling in the lexer between ByteStrings and RawByteStrings - Detect potentially intended terminators (longest sequence of "#*" is suggested)

This is a pure refactoring with no behavior changes.

This is a follow-up to rust-lang#70123, which added `llvm-config --libdir` to the `LIBRARY_PATH` for rustc tools. We need the same for "run-make-fulldeps" and "ui-fulldeps" tests which depend on compiler libraries, implicitly needing to link to `-lLLVM` as well.

…t's Copy

bors · 2020-04-01T12:34:12Z

⌛ Testing commit c1419b4 with merge 5ab42ba86a9f77a7c961bfd7e362e9647471c5da...

Centril · 2020-04-01T12:36:12Z

@bors treeclosed=500

bors · 2020-04-01T12:38:38Z

💔 Test failed - checks-azure

Centril · 2020-04-01T12:44:31Z

@bors retry

Centril · 2020-04-01T12:44:41Z

@bors p=1000

bors · 2020-04-01T12:44:50Z

⌛ Testing commit c1419b4 with merge cd9540e58384763651b11f178fcbfad1d258e488...

rust-highfive · 2020-04-01T14:16:55Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-01T12:33:00.3587852Z ========================== Starting Command Output ===========================
2020-04-01T12:33:00.3590201Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/673fa107-69ae-44bf-96df-54a165936421.sh
2020-04-01T12:33:00.3590433Z 
2020-04-01T12:33:00.3593447Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-01T12:33:00.3611291Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70653/merge to s
2020-04-01T12:33:00.3614534Z Task         : Get sources
2020-04-01T12:33:00.3614800Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T12:33:00.3615057Z Version      : 1.0.0
2020-04-01T12:33:00.3615231Z Author       : Microsoft
---
2020-04-01T12:33:01.5570746Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-01T12:33:01.5583641Z ##[command]git config gc.auto 0
2020-04-01T12:33:01.5590966Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-01T12:33:01.5596435Z ##[command]git config --get-all http.proxy
2020-04-01T12:33:01.5613315Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70653/merge:refs/remotes/pull/70653/merge
---
2020-04-01T12:34:20.8748255Z E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
2020-04-01T12:34:20.8791433Z 
2020-04-01T12:34:20.8874137Z ##[error]Bash exited with code '100'.
2020-04-01T12:34:20.8888282Z ##[section]Finishing: Install awscli
2020-04-01T12:34:20.8954770Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70653/merge to s
2020-04-01T12:34:20.8959599Z Task         : Get sources
2020-04-01T12:34:20.8959963Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T12:34:20.8960277Z Version      : 1.0.0
2020-04-01T12:34:20.8960499Z Author       : Microsoft
2020-04-01T12:34:20.8960499Z Author       : Microsoft
2020-04-01T12:34:20.8960874Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-01T12:34:20.8961282Z ==============================================================================
2020-04-01T12:34:21.2452384Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-01T12:34:21.2514782Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70653/merge to s
2020-04-01T12:34:21.2616437Z Cleaning up task key
2020-04-01T12:34:21.2617718Z Start cleaning up orphan processes.
2020-04-01T12:34:21.2804140Z Terminate orphan process: pid (3672) (python)
2020-04-01T12:34:21.3017358Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-04-01T14:20:53Z

💔 Test failed - checks-azure

Centril · 2020-04-01T14:21:27Z

@bors retry

bors · 2020-04-01T14:21:37Z

⌛ Testing commit c1419b4 with merge 235938d...

bors · 2020-04-01T17:09:25Z

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 235938d to master...

rust-highfive · 2020-04-01T17:10:54Z

📣 Toolstate changed by #70653!

Tested on commit 235938d.
Direct link to PR: #70653

💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).

@mcarton

Tested on commit rust-lang/rust@235938d. Direct link to PR: <rust-lang/rust#70653> 💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). 💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).

rcoh and others added 30 commits March 27, 2020 22:02

Move raw string tests into the raw directory

840a576

Add -Z dump-mir-dataflow

4d099e6

dump_enabled takes a DefId instead of MirSource

edbd7c8

Dump graphviz dataflow results with flag

c800402

Ensure output dir for dataflow results exists

4d1194c

Cleanup error messages, improve docstrings

c15f86b

More raw string tests

82b2989

Cleanup match expression

bceab25

Clean up redudant conditions and match exprs

20e2190

Add can_unwind field to FnAbi

097e9e5

This is a pure refactoring with no behavior changes.

Fix tests to handle debug_assert

55a5eea

Use Place directly, it's Copy

d45dca3

Use Place directly on propagate_closure_used_mut_place, it's Copy

f026441

Use Place directly on borrow_of_local_data, it's Copy

a67b28a

Use Place directly on remove_never_initialized_mut_locals, it's Copy

32a7618

Use Place directly on check_mut_borrowing_layout_constrained_field, i…

760bca4

…t's Copy

Use Place directly, it's Copy more use cases

25528c1

Use Place directly, it's Copy even more use cases

890b393

Use Place directly on Operand::place and friends, it's Copy

6a95bf8

Use Place directly in librustc_mir_build, it's Copy

f37d2b8

Use Place directly in place_as_reborrow, it's Copy

5987b0f

Use Place directly on place_contents_drop_state_cannot_differ, it's Copy

947c1dc

Use Place directly in peek_at, it's Copy

017620f

Use Place directly on codegen_drop_terminator, it's Copy

afcd7fc

Use Place directly on make_return_dest, it's Copy

5f8a6ed

Use Place directly in codegen_transmute, it's Copy

1f5338c

Use Place directly in evaluate_array_len, it's Copy

a865e77

Use Place directly in codegen_place_to_pointer, it's Copy

017608f

Centril added the rollup A PR which is a rollup label Apr 1, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 1, 2020

bors merged commit 235938d into rust-lang:master Apr 1, 2020

This was referenced Apr 1, 2020

clippy-driver no longer builds after rust-lang/rust#70653 #70663

Closed

miri no longer builds after rust-lang/rust#70653 #70664

Closed

bors mentioned this pull request Apr 1, 2020

Remove some reexports in rustc_middle #70634

Merged

Centril deleted the rollup-vh5x5e5 branch April 1, 2020 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #70653

Rollup of 6 pull requests #70653

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

Centril commented Apr 1, 2020

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

rust-highfive commented Apr 1, 2020

bors commented Apr 1, 2020

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

bors commented Apr 1, 2020

rust-highfive commented Apr 1, 2020

Rollup of 6 pull requests #70653

Rollup of 6 pull requests #70653

Conversation

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

Centril commented Apr 1, 2020

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

rust-highfive commented Apr 1, 2020

bors commented Apr 1, 2020

Centril commented Apr 1, 2020

bors commented Apr 1, 2020

bors commented Apr 1, 2020

rust-highfive commented Apr 1, 2020