-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix abuses of tykind::err #70870
Fix abuses of tykind::err #70870
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ugh so it doesn't work there either. Just use |
@eddyb It seems to be past the ICE now, but src/test/ui/issues/issue-69841.rs is reaching unreachable code on line 28. I don't understand how these changes can cause that. EDIT: CI is passing, so maybe this is just a stage 1/incremental bug? |
@bors r+ (cc @nikomatsakis) |
📌 Commit daddf4d has been approved by |
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
Rollup of 7 pull requests Successful merges: - rust-lang#70134 (add basic support of OsStrExt for HermitCore) - rust-lang#70565 (Add inline attributes for functions used in the query system) - rust-lang#70828 (rustdoc: Don't try to load source files from external crates) - rust-lang#70870 (Fix abuses of tykind::err) - rust-lang#70906 (Suggest move for closures and async blocks in more cases.) - rust-lang#70912 (Do not suggest adding type param when `use` is already suggested) - rust-lang#70930 (add tracking issue to `VecDeque::make_contiguous`) Failed merges: r? @ghost
r? @eddyb
cc #70866