Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide suggestions for type parameters missing bounds for associated types #70908

Merged
merged 8 commits into from
May 7, 2020
Merged

Provide suggestions for type parameters missing bounds for associated types #70908

merged 8 commits into from
May 7, 2020
+629 −224

Commits on May 4, 2020

  1. Handle binop on unbound type param 

    When encountering a binary operation involving a type parameter that has
no bindings, suggest adding the appropriate bound.
    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    75f066d View commit details
    Browse the repository at this point in the history

  2. Suggest restricting type param when it doesn't satisfy projection 

    When encountering a projection that isn't satisfied by a type parameter,
suggest constraining the type parameter.
    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    1473a66 View commit details
    Browse the repository at this point in the history

  3. review comments: use or-pattern

    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    3453db7 View commit details
    Browse the repository at this point in the history

  4. On incorrect equality constraint likely to be assoc type, suggest app… 

    …ropriate syntax

When encountering `where <A as Foo>::Bar = B`, it is possible that `Bar`
is an associated type. If so, suggest `where A: Foo<Bar = B>`.

CC rust-lang#20041.
    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    d8d02f8 View commit details
    Browse the repository at this point in the history

  5. review comments and rebase fix

    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    c93c660 View commit details
    Browse the repository at this point in the history

  6. review comment: use body_id

    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    5d64e91 View commit details
    Browse the repository at this point in the history

  7. fix rebase

    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    b13f234 View commit details
    Browse the repository at this point in the history

  8. Add docstring to deny_equality_constraints

    @estebank
    estebank committed May 4, 2020
    Configuration menu
    Copy the full SHA
    b17b20c View commit details
    Browse the repository at this point in the history