Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false "never constructed" warnings for Self:: variant paths #71026

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Fix false "never constructed" warnings for Self:: variant paths #71026

merged 2 commits into from
Apr 19, 2020

Conversation

seiyab
Copy link
Contributor

@seiyab seiyab commented Apr 11, 2020

Closes #64362 .

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2020
@seiyab seiyab mentioned this pull request Apr 11, 2020
Closed
@seiyab
Copy link
Contributor Author

seiyab commented Apr 19, 2020

What CI / PR does?
I can neither read detail log nor find docs.

@varkor
Copy link
Member

varkor commented Apr 19, 2020

@seiyab: huh, I'm actually not sure why those tests failed. There seemed to be no log attached, as you say. I've restarted them, so hopefully they'll work properly this time.

@seiyab
Copy link
Contributor Author

seiyab commented Apr 19, 2020

They have a trouble to check out the code...
They check out to 01a37fef4bf59d4a3adac9b32b1cbc6197a5332a rather than refs/pull/71026/merge .
I don't know the reason.

@varkor
Copy link
Member

varkor commented Apr 19, 2020

Maybe you could try rebasing on top of the current master? If this doesn't work, I'll investigate further.

@seiyab
Copy link
Contributor Author

seiyab commented Apr 19, 2020

@varkor
Thank you to restart pipelines and friendly advice.
I'll try rebasing.

@seiyab
Copy link
Contributor Author

seiyab commented Apr 19, 2020

@varkor
Your advice helps.
CI / PR (x86_64-gnu-tools) succeeded.
Thank you very much 😄

@varkor
Copy link
Member

varkor commented Apr 19, 2020

@seiyab: thanks for the fix!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 19, 2020

📌 Commit d3f8db6 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 19, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2020
@bors
Auto merge of rust-lang#71331 - Dylan-DPC:rollup-5rn1isc, r=Dylan-DPC
dbf8b6b 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#71026 (Fix false "never constructed" warnings for `Self::` variant paths)
 - rust-lang#71310 (Do not show DefId in diagnostics)
 - rust-lang#71317 (miri-unleash test for llvm_asm)
 - rust-lang#71324 (Fix some tests failing in `--pass check` mode)

Failed merges:

r? @ghost
@bors bors merged commit 9c5da9a into rust-lang:master Apr 19, 2020
@seiyab seiyab deleted the issue-64362-adhoc branch April 20, 2020 00:03
@seiyab
Copy link
Contributor Author

seiyab commented Apr 20, 2020

@varkor
Thank you for your review and merging.
I'm very happy and proud of contributing Rust, that I like 😆

@Lonami Lonami mentioned this pull request Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"variant is never constructed" lint appears to be incorrect?
5 participants
@seiyab @rust-highfive @varkor @bors @jakubadamw