Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document unsafety in core::{option, hash} #71063

Merged
merged 5 commits into from
Apr 24, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Helps with #66219.
I think that the part that will need reviewing the most is the hash/sip.rs file.
r? @LukasKalbertodt (or someone else from the libs team)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2020
@Centril
Copy link
Contributor

Centril commented Apr 13, 2020

cc @RalfJung

@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2020
src/libcore/hash/mod.rs Show resolved Hide resolved
src/libcore/hash/mod.rs Show resolved Hide resolved
src/libcore/hash/mod.rs Show resolved Hide resolved
src/libcore/option.rs Show resolved Hide resolved
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2020
LeSeulArtichaut and others added 2 commits April 23, 2020 18:32
Co-authored-by: Mark-Simulacrum <mark.simulacrum@gmail.com>
Co-Authored-By: Mark-Simulacrum <mark.simulacrum@gmail.com>
@LeSeulArtichaut
Copy link
Contributor Author

@Mark-Simulacrum If you don't have any other remark I think this is ready to be r+'d!

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

I agree!

@bors
Copy link
Contributor

bors commented Apr 23, 2020

📌 Commit a694315 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 23, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 23, 2020
…Mark-Simulacrum

Document unsafety in core::{option, hash}

Helps with rust-lang#66219.
I think that the part that will need reviewing the most is the `hash/sip.rs` file.
r? @LukasKalbertodt (or someone else from the libs team)
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#70845 (Make the `structural_match` error diagnostic for const generics clearer)
 - rust-lang#71063 (Document unsafety in core::{option, hash})
 - rust-lang#71068 (Stabilize UNICODE_VERSION (feature unicode_version))
 - rust-lang#71426 (fix error code in E0751.md)
 - rust-lang#71459 (Add leading 0x to offset in Debug fmt of Pointer)
 - rust-lang#71492 (Document unsafety in core::{panicking, alloc::layout, hint, iter::adapters::zip})

Failed merges:

r? @ghost
@@ -279,10 +278,13 @@ impl<S: Sip> super::Hasher for Hasher<S> {

// Buffered tail is now flushed, process new input.
let len = length - needed;
let left = len & 0x7;
let left = len & 0x7; // len % 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect rustc do this optimization. Why not replace the code with len % 8?

@bors bors merged commit 9ff020e into rust-lang:master Apr 24, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the document-unsafe branch April 24, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants