Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why we shouldn't add inline attr to into_vec #71287

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

JohnTitor
Copy link
Member

Follow-up of #71204
r? @RalfJung

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2020
@RalfJung
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 18, 2020

📌 Commit 1a46159 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 18, 2020
Explain why we shouldn't add inline attr to into_vec

Follow-up of rust-lang#71204
r? @RalfJung
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 18, 2020
Explain why we shouldn't add inline attr to into_vec

Follow-up of rust-lang#71204
r? @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71271 (Move `MapInPlace` to rustc_data_structures)
 - rust-lang#71276 (miri-unleashed: test that we detect heap allocations)
 - rust-lang#71283 (Minor improvements to -Zprofile)
 - rust-lang#71287 (Explain why we shouldn't add inline attr to into_vec)
 - rust-lang#71303 (remove build warnings)

Failed merges:

r? @ghost
@bors bors merged commit dfdfc76 into rust-lang:master Apr 19, 2020
@JohnTitor JohnTitor deleted the comment-vec branch April 19, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants