Add -Cbitcode-in-rlib.
#71323
Merged
Add -Cbitcode-in-rlib.
#71323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
This will need rust-lang/cargo#8134 to land first, and then I can add another commit that updates cargo. And #70729 also needs to land, and then I can remove the "XXX" commit. |
|
r=me once the relevant bits all land |
nnethercote
force-pushed
the
bitcode-in-rlib
branch
from
56dde3f
to
64297c0
Compare
|
@compiler-team: this is a cut-down alternative to #70458. That PR moved LLVM bitcode from a This PR is much simpler. It adds a new flag, This goes back to the original idea from #66598, before it got pulled into a more expansive, but ultimately infeasible, direction. It attains all the performance benefits that #70458 did. Normally a new |
|
cc @rust-lang/compiler (the compiler-team org on github isn't related) |
|
I should add some kind of test here, but I'm not sure what it would look like. |
|
Uh, not sure why I'm getting this test failure: This PR doesn't touch anything that I would expect to have an effect like that. |
|
@nnethercote That error is from miri, which was broken by #70629. When you update a submodule, it triggers the submodule builder for PRs. But the miri error isn't the problem (miri failures are ignored at all times). The PR breaks RLS: We'll need to update RLS. I'll get started on a PR, though it will probably be better just to wait till after the beta branch. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nnethercote
force-pushed
the
bitcode-in-rlib
branch
from
64297c0
to
b21ace1
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@nnethercote want to back out the Cargo update, land this, and we can get the Cargo update in later? |
|
☔ The latest upstream changes (presumably #70729) made this pull request unmergeable. Please resolve the merge conflicts. |
nnethercote
force-pushed
the
bitcode-in-rlib
branch
from
b21ace1
to
b1dc691
Compare
I think it's easier to land it all together. Plus, having the Cargo update here means I can do a perf CI run to make sure everything is working: @bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit b1dc6912e99847edcf6572bf404a8994dc63183a with merge b517c76f80a97f79f2053eac2db941dcc6ab9be4... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☀️ Try build successful - checks-azure |
|
Queued b517c76f80a97f79f2053eac2db941dcc6ab9be4 with parent 20fc02f, future comparison URL. |
RalfJung
reviewed
Apr 21, 2020
|
Finished benchmarking try commit b517c76f80a97f79f2053eac2db941dcc6ab9be4, comparison URL. |
nnethercote
force-pushed
the
bitcode-in-rlib
branch
from
b1dc691
to
dde2d00
Compare
|
Perf results are as expected. @bors r=alexcrichton |
|
📌 Commit dde2d00921645a87f27ad7c4dc0728663ca7ce4b has been approved by |
bors
removed
the
S-waiting-on-review
|
@bors r=alexcrichton |
|
📌 Commit 4a7c348ecc53bfa5123cb4b59a6850432f290a5e has been approved by |
|
@bors p=1 Because of the performance win. |
|
@bors rollup=never |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Merged
|
☔ The latest upstream changes (presumably #71402) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
This comment wasn't supposed to have landed.
It defaults to true, but Cargo will set this to false whenever it can to reduce compile times.
So that the rlibs will work with both LTO and non-LTO builds.
nnethercote
force-pushed
the
bitcode-in-rlib
branch
from
4a7c348
to
a105c5c
Compare
|
@bors r=alexcrichton |
|
📌 Commit a105c5c has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
This was referenced Apr 22, 2020
Merged
This was referenced Apr 22, 2020
This was referenced May 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cut-down version of #70458 that gets the compile-time wins.
r? @alexcrichton