Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hold the predecessor cache lock longer than necessary #71392

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Don't hold the predecessor cache lock longer than necessary #71392

merged 3 commits into from
Apr 26, 2020

Commits on Apr 23, 2020

  1. Remove predecessors_for 

    There is no `Arc::map` equivalent to `LockGuard::map`
    @ecstatic-morse
    ecstatic-morse committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    740f228 View commit details
    Browse the repository at this point in the history

  2. Use a ref-counted pointer for ownership of the predecessor cache 

    ...instead of a `LockGuard` which means the lock is held for longer than
necessary.
    @ecstatic-morse
    ecstatic-morse committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    59c7460 View commit details
    Browse the repository at this point in the history

  3. Add module docs and restrict visibility

    @ecstatic-morse
    ecstatic-morse committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    34dfbc3 View commit details
    Browse the repository at this point in the history