Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #71410

Merged
merged 22 commits into from
Apr 22, 2020
Merged

Rollup of 7 pull requests #71410

merged 22 commits into from
Apr 22, 2020

Commits on Apr 20, 2020

  1. Remove unused dependencies

    sinkuu committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    33905ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fae4e2a View commit details
    Browse the repository at this point in the history
  3. Suggest -> impl Trait and -> Box<dyn Trait> on fn that doesn't re…

    …turn
    
    During development, a function could have a return type set that is a
    bare trait object by accident. We already suggest using either a boxed
    trait object or `impl Trait` if the return paths will allow it. We now
    do so too when there are *no* return paths or they all resolve to `!`.
    We still don't handle cases where the trait object is *not* the entirety
    of the return type gracefully.
    estebank committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    d3c96f0 View commit details
    Browse the repository at this point in the history
  4. Ensure tail expression will have a Ty for E0746

    When the return type is `!Sized` we look for all the returned
    expressions in the body to fetch their types and provide a reasonable
    suggestion. The tail expression of the body is normally evaluated after
    checking whether the return type is `Sized`. Changing the order of the
    evaluation produces undesirable knock down effects, so we detect the
    specific case that newcomers are likely to encounter ,returning a single
    bare trait object, and only in that case we evaluate the tail
    expression's type so that the suggestion will be accurate.
    estebank committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    e536257 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9fc0833 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4ddf661 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6850e4a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9af047f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Fix #! (shebang) stripping account space issue rust-lang#70528

    Ayush Kumar Mishra committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    0315864 View commit details
    Browse the repository at this point in the history
  2. Refactoring and added test-cases rust-lang#70528

    Ayush Kumar Mishra committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    ee5a212 View commit details
    Browse the repository at this point in the history
  3. Fix formatting issue

    Ayush Kumar Mishra committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    365b3cc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20de922 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e2901c4 View commit details
    Browse the repository at this point in the history
  6. Minor refactoring

    Ayush Kumar Mishra committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    1b362cd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    410fc9d View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Rollup merge of rust-lang#70998 - estebank:suggest-impl-trait-empty-f…

    …n, r=varkor
    
    Suggest `-> impl Trait` and `-> Box<dyn Trait>` on fn that doesn't return
    
    During development, a function could have a return type set that is a
    bare trait object by accident. We already suggest using either a boxed
    trait object or `impl Trait` if the return paths will allow it. We now
    do so too when there are *no* return paths or they all resolve to `!`.
    We still don't handle cases where the trait object is *not* the entirety
    of the return type gracefully.
    
    Closes rust-lang#38376.
    JohnTitor committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    24fb393 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#71236 - sinkuu:cleanup, r=nikomatsakis

    Remove unused rustc_serialize::hex module
    
    * Remove unused `rustc_serialize::hex` module
    * Cleanup `Cargo.toml`
    JohnTitor committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    567e54f View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#71366 - faern:use-assoc-int-consts3, r=dtolnay

    Use assoc int consts3
    
    Define module level int consts with associated constants instead of `min_value()` and `max_value()`. So the code become consistent with what the docs recommend etc. Seems natural.
    
    Also remove the last usages of the int module constants from this repo (except src/test/ directory which I have still not really done anything in). Some places were missed in the previous PRs because the code uses `crate::<IntTy>` to reach the constants.
    
    This is a continuation of rust-lang#70857
    
    r? @dtolnay
    JohnTitor committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    f28e387 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#71372 - ayushmishra2005:shebang_stripping, …

    …r=estebank
    
    Fix #! (shebang) stripping account space issue
    
     rust-lang#70528
    JohnTitor committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    46a8dce View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#71384 - RalfJung:RalfJung-patch-1, r=Mark-S…

    …imulacrum
    
    Fix stage0.txt version number comment
    
    r? @Mark-Simulacrum
    JohnTitor committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    836a64a View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#71390 - aticu:master, r=Dylan-DPC

    Fix incorrect description of E0690
    
    r? @steveklabnik
    JohnTitor committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    3efa70f View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#71399 - rust-lang:cleanup-e0554, r=Dylan-DPC

    Clean up E0554 explanation
    
    r? @Dylan-DPC
    JohnTitor committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    66eaead View commit details
    Browse the repository at this point in the history