Add caches for method and impl metadata #7144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lookups for these items in external crates currently cause repeated decoding of the EBML metadata, which is pretty slow. Adding caches to avoid the repeated decoding reduces the time required for the type checking of librustc by about 25%.
bors
added a commit
that referenced
this pull request
Jun 15, 2013
The lookups for these items in external crates currently cause repeated decoding of the EBML metadata, which is pretty slow. Adding caches to avoid the repeated decoding reduces the time required for the type checking of librustc by about 25%.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 6, 2021
…flip1995 while_immutable_cond: check condition for mutation This fixes rust-lang#6689 by also checking the bindings mutated in the condition, whereas it was previously only checked in the loop body. --- changelog: Fix FP in [`while_immutable_cond`] where mutation in the loop variable wasn't picked up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lookups for these items in external crates currently cause repeated
decoding of the EBML metadata, which is pretty slow. Adding caches to
avoid the repeated decoding reduces the time required for the type
checking of librustc by about 25%.