Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated reference to interpreter snapshotting #71452

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

ecstatic-morse
Copy link
Contributor

This should have been a part of #70087.

r? @RalfJung

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@RalfJung
Copy link
Member

Good catch, thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 23, 2020

📌 Commit e97c227 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2020
@RalfJung
Copy link
Member

I wonder if now more fields can become private? I seem to recall we left something public just for snapshotting... but maybe that was before we made bytes private.

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 23, 2020
…RalfJung

Remove outdated reference to interpreter snapshotting

This should have been a part of rust-lang#70087.

r? @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#71005 (Reading from the return place is fine)
 - rust-lang#71198 (Const check/promotion cleanup and sanity assertion)
 - rust-lang#71396 (Improve E0308 error message wording again)
 - rust-lang#71452 (Remove outdated reference to interpreter snapshotting)
 - rust-lang#71454 (Inline some function docs in `core::ptr`)
 - rust-lang#71461 (Improve E0567 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 414355b into rust-lang:master Apr 23, 2020
@ecstatic-morse ecstatic-morse deleted the no-more-snapshot branch October 6, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants