Rename AssociatedItems to AssocItems #71511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @eddyb |
|
@eddyb Could you please take a look? Thanks! |
|
☔ The latest upstream changes (presumably #70674) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
resolve conflicts
Rustin170506
force-pushed
the
rustin-patch-rename-assoc
branch
from
39d640f
to
6c3f5b8
Compare
|
Resolved conflicts. Ready for review. cc: @eddyb I don't know if this PR is still acceptable because it's been a long time. |
|
LGTM, r? @varkor |
|
@bors r=eddyb,varkor |
|
📌 Commit 6c3f5b8 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6c3f5b8 with merge c6820bd00f932d16ace0afe9bfe1f08807d5c44a... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
|
@hi-rustin: 🔑 Insufficient privileges: not in try users |
|
The CI failed because: #84394 |
|
@bors retry |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
…, r=eddyb,varkor Rename AssociatedItems to AssocItems Signed-off-by: Rustin-Liu <rustin.liu@gmail.com> Part of rust-lang#60163 (comment)
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
…, r=eddyb,varkor Rename AssociatedItems to AssocItems Signed-off-by: Rustin-Liu <rustin.liu@gmail.com> Part of rust-lang#60163 (comment)
This was referenced Apr 22, 2021
|
⌛ Testing commit 6c3f5b8 with merge 757bdef0c555409bc8bc7b37528958558a3ba160... |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
…, r=eddyb,varkor Rename AssociatedItems to AssocItems Signed-off-by: Rustin-Liu <rustin.liu@gmail.com> Part of rust-lang#60163 (comment)
|
@bors retry (yield to rollup) |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
…, r=eddyb,varkor Rename AssociatedItems to AssocItems Signed-off-by: Rustin-Liu <rustin.liu@gmail.com> Part of rust-lang#60163 (comment)
|
⌛ Testing commit 6c3f5b8 with merge a020c08a48f7107479c27c15fbdf16b75b7a8cf8... |
|
@bors retry yield |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rustin-Liu rustin.liu@gmail.com
Part of #60163 (comment)