Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thread_local with generator resume arguments in box_region. #71554

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Replace thread_local with generator resume arguments in box_region. #71554

merged 1 commit into from
Apr 26, 2020

Conversation

gizmondo
Copy link
Contributor

Fixes #68922.

Continuation of #70622. Added a short doc, hope it makes sense.

r? @jonas-schievink

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2020
jonas-schievink
jonas-schievink reviewed Apr 25, 2020
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I only have a couple of formatting nits.

src/librustc_data_structures/box_region.rs Outdated Show resolved Hide resolved
src/librustc_data_structures/box_region.rs Outdated Show resolved Hide resolved
@gizmondo
Copy link
Contributor Author

Nice! I only have a couple of formatting nits.

Ah sure, thanks.

@jonas-schievink
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2020

📌 Commit 357f4ce has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 25, 2020
@Dylan-DPC
Rollup merge of rust-lang#71554 - gizmondo:68922, r=jonas-schievink
4f1e717 
Replace thread_local with generator resume arguments in box_region.

Fixes rust-lang#68922.

Continuation of rust-lang#70622. Added a short doc, hope it makes sense.

r? @jonas-schievink
This was referenced Apr 25, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2020
@bors
Auto merge of rust-lang#71566 - Dylan-DPC:rollup-9xoz6fg, r=Dylan-DPC
b592b37 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70043 (Add all remaining `DefKind`s.)
 - rust-lang#71140 ([breaking change] Disallow statics initializing themselves)
 - rust-lang#71392 (Don't hold the predecessor cache lock longer than necessary)
 - rust-lang#71541 (Add regression test for rust-lang#26376)
 - rust-lang#71554 (Replace thread_local with generator resume arguments in box_region.)

Failed merges:

r? @ghost
@bors bors merged commit f70c9db into rust-lang:master Apr 26, 2020
@gizmondo gizmondo deleted the 68922 branch April 26, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink left review comments

Assignees

@jonas-schievink jonas-schievink

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite box_region.rs to use generator resume arguments
4 participants
@gizmondo @jonas-schievink @bors @rust-highfive