Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix more clippy warnings #71562

Merged
merged 1 commit into from
Apr 26, 2020
Merged

fix more clippy warnings #71562

merged 1 commit into from
Apr 26, 2020

Conversation

matthiaskrgr
Copy link
Member

clippy::{redundant_pattern_matching, clone_on_copy, iter_cloned_collect, option_as_ref_deref, match_ref_pats}

r? @Dylan-DPC

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2020
@Dylan-DPC-zz
Copy link

looks like ci failed spuriously

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Apr 25, 2020

📌 Commit 6dfcd02d7a6c810bff1bfe75efd9e8b2fade1caa has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2020
@matthiaskrgr
Copy link
Member Author

@Dylan-DPC err, this is not a toolstate fix ^^

@Dylan-DPC-zz
Copy link

oof lol

@bors p=0 rollup=maybe

@Dylan-DPC-zz
Copy link

@bors r-

check CI (probably tidy)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2020
@matthiaskrgr
fix more clippy warnings
8862f82 
clippy::{redundant_pattern_matching, clone_on_copy, iter_cloned_collect, option_as_ref_deref, match_ref_pats}
@matthiaskrgr
Copy link
Member Author

Fixed the formatting.

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 26, 2020

📌 Commit 8862f82 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 26, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2020
@bors
Auto merge of rust-lang#71579 - Dylan-DPC:rollup-h9om2g3, r=Dylan-DPC
7f3b3df 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71490 (Cleanup and document `-C relocation-model`)
 - rust-lang#71562 (fix more clippy warnings)
 - rust-lang#71571 (Fix since attribute for nonzero_bitor impl's)
 - rust-lang#71574 (proc_macro: Fix since attributes for new Span methods)
 - rust-lang#71575 (Fix stable(since) attribute for BTreeMap::remove_entry)

Failed merges:

r? @ghost
@bors bors merged commit 3b3f7bd into rust-lang:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @Dylan-DPC-zz @bors @rust-highfive