impl PartialEq<Vec> for &[A], &mut [A] #71660

sollyucko · 2020-04-29T02:13:43Z

rust-highfive · 2020-04-29T02:13:47Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

shepmaster · 2020-04-29T11:23:11Z

r? @kennytm

marmeladema · 2020-04-29T11:56:58Z

I am definitely not a compiler-team member and I don't want to overstep any boundaries here, so I apologize in advance if I do, just let me know. But should this kind of change requires some tests?

shepmaster · 2020-04-29T12:01:01Z

I would agree that some tests should be added, specifically those exercising the specific equality being added. Also, I’d have some assert_eq usages as this comes up as a common usage.

kennytm · 2020-04-29T12:18:54Z

@shepmaster ya know I can't start the required FCP for this insta-stable PR since I'm not in the libs team 🙃

shepmaster · 2020-04-29T13:40:20Z

ya know

I appreciate that you think I know anything. What I know is that you are a thorough reviewer (like one who realized that this would be insta-stable and thus needs a RFC).

shepmaster · 2020-04-29T13:41:37Z

r? @LukasKalbertodt

shepmaster

The "slice"s are not slices; that needs to be changed.

You don't have to follow this, but I would have written the tests to lean on the type checker more. Something like:

fn compare_vec_and_array(v: Vec<i32>, a: [i32; 3]) {
    let _ = v == a;
    let _ = a == v;

    assert_eq!(v, a);
    assert_eq!(a, v);
}

fn compare_vec_and_slice(v: Vec<i32>, s: &[i32]) { /* ... */ }

// Optionally make these take in `Vec<T>`?

I don't know if I would even call these functions; their existence proves that the traits exist. I might call them just to prove that they were compiled.

I also advocate for having smaller tests with better names. That way, when a test fails, you can tell what failed by the name, and it's easier to see what is being tested.

src/liballoc/tests/vec.rs

sollyucko · 2020-04-29T15:01:17Z

I'm still keeping the mega-test for thoroughness, but I can remove it if you'd prefer.

dtolnay · 2020-06-20T23:06:21Z

@bors r+

bors · 2020-06-20T23:06:22Z

📌 Commit 4896a06 has been approved by dtolnay

impl PartialEq<Vec> for &[A], &mut [A] rust-lang/rfcs#2917

bors · 2020-06-22T12:53:04Z

⌛ Testing commit 4896a06 with merge 3de9e530d523ca4a2386e981b9e1cd89a6b9fa34...

Dylan-DPC-zz · 2020-06-22T12:59:51Z

included in rollup (accidentally two of them :P )

@bors retry

@ghost

Rollup of 6 pull requests Successful merges: - rust-lang#71660 (impl PartialEq<Vec> for &[A], &mut [A]) - rust-lang#72623 (Prefer accessible paths in 'use' suggestions) - rust-lang#73502 (Add E0765) - rust-lang#73580 (deprecate wrapping_offset_from) - rust-lang#73582 (Miri: replace many bug! by span_bug!) - rust-lang#73585 (Do not send a notification for P-high stable regressions) Failed merges: - rust-lang#73581 (Create 0766 error code) r? @ghost

according to various people on tech-pkg@, there are no problems with the Firefox build Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.][72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you cast a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.][72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

Add PartialEq impls for Vec <-> slice This is a follow-up to rust-lang#71660 and rust-lang/rfcs#2917 to add two more missing vec/slice PartialEq impls: ``` impl<A, B> PartialEq<[B]> for Vec<A> where A: PartialEq { .. } impl<A, B> PartialEq<Vec> for [A] where A: PartialEq { .. } ``` Since this is insta-stable, it should go through the `@rust-lang/libs` FCP process. Note that I used version 1.47.0 for the `stable` attribute because I assume this will not merge before the 1.46.0 branch is cut next week.

Pkgsrc changes: * Portability patches for Illumos have been intregrated upstream, so are no longer needed in pkgsrc. * Adjust one other patch, and update vendor/libc cargo checksum. Upstream changes: Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.] [72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you have a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.] [72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

rust-highfive assigned withoutboats Apr 29, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2020

sollyucko force-pushed the master branch from 0fe0b0a to 7ffca72 Compare April 29, 2020 02:26

This comment has been minimized.

Sign in to view

sollyucko force-pushed the master branch from 7ffca72 to 497a443 Compare April 29, 2020 02:33

This comment has been minimized.

Sign in to view

sollyucko force-pushed the master branch from 497a443 to 80c758a Compare April 29, 2020 02:40

jonas-schievink added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 29, 2020

jonas-schievink added this to the 1.45 milestone Apr 29, 2020

rust-highfive assigned kennytm and unassigned withoutboats Apr 29, 2020

rust-highfive assigned LukasKalbertodt and unassigned kennytm Apr 29, 2020

sollyucko force-pushed the master branch 3 times, most recently from 70a4b90 to 1d93212 Compare April 29, 2020 14:30

shepmaster previously requested changes Apr 29, 2020

View reviewed changes

src/liballoc/tests/vec.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

sollyucko force-pushed the master branch from f9da890 to eb6aaf4 Compare April 29, 2020 16:47

sollyucko requested a review from shepmaster April 29, 2020 20:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2020

dtolnay approved these changes Jun 20, 2020

View reviewed changes

dtolnay modified the milestones: 1.45, 1.46 Jun 20, 2020

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 21, 2020

Rollup merge of rust-lang#71660 - sollyucko:master, r=dtolnay

ecf0dbe

impl PartialEq<Vec> for &[A], &mut [A] rust-lang/rfcs#2917

Manishearth mentioned this pull request Jun 21, 2020

Rollup of 14 pull requests #73598

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 21, 2020

Rollup merge of rust-lang#71660 - sollyucko:master, r=dtolnay

c062ce5

impl PartialEq<Vec> for &[A], &mut [A] rust-lang/rfcs#2917

Manishearth mentioned this pull request Jun 21, 2020

Rollup of 11 pull requests #73599

Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2020

Rollup merge of rust-lang#71660 - sollyucko:master, r=dtolnay

71e7bd2

impl PartialEq<Vec> for &[A], &mut [A] rust-lang/rfcs#2917

Manishearth mentioned this pull request Jun 22, 2020

Rollup of 13 pull requests #73604

Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 22, 2020

Rollup merge of rust-lang#71660 - sollyucko:master, r=dtolnay

158b3d4

impl PartialEq<Vec> for &[A], &mut [A] rust-lang/rfcs#2917

Dylan-DPC-zz mentioned this pull request Jun 22, 2020

Rollup of 5 pull requests #73615

Closed

Dylan-DPC-zz mentioned this pull request Jun 22, 2020

Rollup of 6 pull requests #73617

Merged

bors merged commit 8da1dd0 into rust-lang:master Jun 22, 2020

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 23, 2020

mbrubeck mentioned this pull request Jul 9, 2020

Add PartialEq impls for Vec <-> slice #74194

Merged

dylni mentioned this pull request Jan 23, 2021

Remove requirement that forces symmetric and transitive PartialEq impls to exist #81198

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

impl PartialEq<Vec<B>> for &[A], &mut [A] #71660

impl PartialEq<Vec<B>> for &[A], &mut [A] #71660

sollyucko commented Apr 29, 2020 •

edited by dtolnay

Loading

rust-highfive commented Apr 29, 2020

This comment has been minimized.

This comment has been minimized.

shepmaster commented Apr 29, 2020

marmeladema commented Apr 29, 2020

shepmaster commented Apr 29, 2020

kennytm commented Apr 29, 2020

shepmaster commented Apr 29, 2020

shepmaster commented Apr 29, 2020

shepmaster left a comment •

edited

Loading

sollyucko commented Apr 29, 2020

This comment has been minimized.

This comment has been minimized.

dtolnay commented Jun 20, 2020

bors commented Jun 20, 2020

bors commented Jun 22, 2020

Dylan-DPC-zz commented Jun 22, 2020

impl PartialEq<Vec<B>> for &[A], &mut [A] #71660

impl PartialEq<Vec<B>> for &[A], &mut [A] #71660

Conversation

sollyucko commented Apr 29, 2020 • edited by dtolnay Loading

rust-highfive commented Apr 29, 2020

This comment has been minimized.

This comment has been minimized.

shepmaster commented Apr 29, 2020

marmeladema commented Apr 29, 2020

shepmaster commented Apr 29, 2020

kennytm commented Apr 29, 2020

shepmaster commented Apr 29, 2020

shepmaster commented Apr 29, 2020

shepmaster left a comment • edited Loading

Choose a reason for hiding this comment

sollyucko commented Apr 29, 2020

This comment has been minimized.

This comment has been minimized.

dtolnay commented Jun 20, 2020

bors commented Jun 20, 2020

bors commented Jun 22, 2020

Dylan-DPC-zz commented Jun 22, 2020

sollyucko commented Apr 29, 2020 •

edited by dtolnay

Loading

shepmaster left a comment •

edited

Loading