add codegen option strip #71825

contrun · 2020-05-03T05:31:08Z

I don't know if the flags added here works for all linkers. I only tested on my Linux pc. I also don't know what is the best for emlinker, PtxLinker, MsvcLinker. The option for WasmLd is copied from https://aransentin.github.io/cwasm/.

rust-highfive · 2020-05-03T05:31:11Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

GabrielMajeri · 2020-05-03T10:44:57Z

Looks good to me, but I think according to the comment in the options.rs file, the following should also be updated:

// If you add a new option, please update:
// - src/librustc_interface/tests.rs
// - src/doc/rustc/src/codegen-options/index.md

contrun · 2020-05-03T11:38:39Z

@GabrielMajeri Thanks. I added the relevant sections in aforementioned files. I don't know if there are still things overlooked.

josephlr

This looks reasonable, but I think we can do better than noop for emscripten and MSVC

josephlr · 2020-05-05T05:08:59Z

src/librustc_codegen_ssa/back/linker.rs

@@ -898,6 +909,10 @@ impl<'a> Linker for EmLinker<'a> {
        });
    }

+    fn strip(&mut self) {
+        // noop


For emscripten, you should try to use --llvm-opts to pass -strip-all to the LLVM toolchain. See the emcc documentation

You may also need something like -Wl to make this work, I'm not sure.

I didn't know if --llvm-opts can be specified multiple times. Can we just add two --llvm-opts and ['--strip-all'] here? Or we should add an field llvmOpts in Emlinker?

src/librustc_codegen_ssa/back/linker.rs

petrochenkov · 2020-05-05T09:08:43Z

This PR introduces the option as immediately stable (-C strip).
New options are usually introduced as unstable (-Z strip) instead.

cramertj · 2020-05-08T18:28:38Z

r? @petrochenkov

petrochenkov · 2020-05-08T23:32:58Z

Upon some closer investigation, I think this should be added in a slightly different form.

-Z strip-debuginfo-if-disabled should be removed.
A new option -Z strip=[none|debuginfo|symbols] should be added.
From implementation point of view Linker::strip should be merged with Linker::debuginfo.

cc #46034 #49212

petrochenkov · 2020-05-08T23:43:40Z

Effect of the option on different platforms:

ELF
- -Z strip=debuginfo -> --strip-debug, strips debuginfo sections and debuginfo symbols from the symbol table section at link time.
- -Z strip=symbols -> --strip-all, same as -Z strip=debuginfo but also strips the rest of the symbol table section. Dynamic symbol table is not stripped, so if we want to load shared libraries we are still good.
PE/COFF + DWARF
- -Z strip=debuginfo -> --strip-debug strips debuginfo sections and debuginfo symbols from the symbol table section at link time.
- -Z strip=symbols -> --strip-all same as -Z strip=debuginfo, but also strips the rest of the symbol table section.
PE/COFF + CodeView
- -Z strip=debuginfo -> /DEBUG:NONE strips debuginfo sections (not copies them to PDB) at link time.
- -Z strip=symbols -> /DEBUG:NONE, same as -Z strip=debuginfo
- We may want so add one more option for /PDBSTRIPPED in the future, but I haven't seen any demand for it so far.

I wouldn't care too much about other target flavors right now, it's safe to do nothing if these options are passed.
If people care about PTX linker etc, they will contribute the proper implementation eventually.

petrochenkov · 2020-05-08T23:56:39Z

GCC doc says that -s (which translates to --strip-all) "removes all ... relocation information from the executable", but ld doc doesn't say that, so I'm not sure what they mean.

The relocations required by dynamic linker are still there, and I assumed that all other relocations are removed during linking anyway as unnecessary.

cc @mati865

tesuji · 2020-05-09T00:55:52Z

I wouldn't care too much about other target flavors right now, it's safe to do nothing if these options are passed.

Would adding a waring about doing nothing for those targets/linkers is better?

mati865 · 2020-05-09T09:42:58Z

Clang will just pass -s to the linker for both Linux and MinGW.
I've tried to find code for that in GCC but had to give up because I've already wasted too much time looking at this mess.

src/librustc_session/config.rs

src/librustc_session/options.rs

src/librustc_codegen_ssa/back/linker.rs

src/librustc_session/options.rs

src/librustc_codegen_ssa/back/linker.rs

src/librustc_codegen_ssa/back/link.rs

petrochenkov · 2020-05-10T08:35:19Z

Great!
r=me after squashing the commits

move strip option to "Z" add more strip options, remove strip-debuginfo-if-disabled merge strip and debuginfo

petrochenkov · 2020-05-10T09:30:21Z

Thanks!
@bors r+

bors · 2020-05-10T09:30:22Z

📌 Commit a6c2f73 has been approved by petrochenkov

bors · 2020-05-10T15:26:50Z

⌛ Testing commit a6c2f73 with merge 0f73d7656803c0a3f9b88595e0dc9590eac4c573...

Dylan-DPC-zz · 2020-05-10T15:28:19Z

@bors retry yield

bors · 2020-05-10T18:11:45Z

⌛ Testing commit a6c2f73 with merge cb49bb804985ac5e7d2df2250f9980bfd306ac42...

Dylan-DPC-zz · 2020-05-10T18:16:36Z

@bors retry yield

bors · 2020-05-10T19:09:03Z

⌛ Testing commit a6c2f73 with merge 69da478ebbb84dd58aabace4bd3c803392cff8cb...

Dylan-DPC-zz · 2020-05-10T19:44:45Z

@bors retry yield

bors · 2020-05-10T20:48:46Z

⌛ Testing commit a6c2f73 with merge aeb4738...

bors · 2020-05-11T00:11:53Z

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing aeb4738 to master...

rust-highfive assigned cramertj May 3, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2020

contrun force-pushed the cg-option-strip branch from 335a242 to 994e075 Compare May 3, 2020 11:37

This comment has been minimized.

Sign in to view

contrun force-pushed the cg-option-strip branch 2 times, most recently from d188309 to 942a16e Compare May 3, 2020 15:28

josephlr reviewed May 5, 2020

View reviewed changes

petrochenkov reviewed May 5, 2020

View reviewed changes

src/librustc_codegen_ssa/back/linker.rs Outdated Show resolved Hide resolved

contrun force-pushed the cg-option-strip branch from 2263797 to 1ee3e7c Compare May 5, 2020 11:10

rust-highfive assigned petrochenkov and unassigned cramertj May 8, 2020

This was referenced May 8, 2020

Symbols blow up binary size to an unreasonable degree on x86_64-unknown-linux-gnu #46034

Closed

Add compiler option to strip symbols from generated binaries #71757

Closed

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2020

petrochenkov reviewed May 9, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

petrochenkov reviewed May 9, 2020

View reviewed changes

src/librustc_session/options.rs Outdated Show resolved Hide resolved

src/librustc_codegen_ssa/back/linker.rs Outdated Show resolved Hide resolved

src/librustc_codegen_ssa/back/linker.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

contrun force-pushed the cg-option-strip branch from cc075e3 to 4fe6ba2 Compare May 10, 2020 03:26

petrochenkov reviewed May 10, 2020

View reviewed changes

src/librustc_codegen_ssa/back/link.rs Outdated Show resolved Hide resolved

contrun force-pushed the cg-option-strip branch from 4fe6ba2 to 169661e Compare May 10, 2020 08:37

add linking option strip

a6c2f73

move strip option to "Z" add more strip options, remove strip-debuginfo-if-disabled merge strip and debuginfo

contrun force-pushed the cg-option-strip branch from 169661e to a6c2f73 Compare May 10, 2020 08:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2020

bors merged commit aeb4738 into rust-lang:master May 11, 2020

petrochenkov mentioned this pull request May 11, 2020

Tracking issue for -Z strip=val option #72110

Closed

retep998 mentioned this pull request Mar 28, 2024

No backtrace on windows with current rustc stable #122857

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add codegen option strip #71825

add codegen option strip #71825

contrun commented May 3, 2020 •

edited

Loading

rust-highfive commented May 3, 2020

GabrielMajeri commented May 3, 2020

contrun commented May 3, 2020

This comment has been minimized.

josephlr left a comment

josephlr May 5, 2020

contrun May 5, 2020

petrochenkov commented May 5, 2020

cramertj commented May 8, 2020

petrochenkov commented May 8, 2020

petrochenkov commented May 8, 2020

petrochenkov commented May 8, 2020 •

edited

Loading

tesuji commented May 9, 2020

mati865 commented May 9, 2020

This comment has been minimized.

This comment has been minimized.

petrochenkov commented May 10, 2020

petrochenkov commented May 10, 2020

bors commented May 10, 2020

bors commented May 10, 2020

Dylan-DPC-zz commented May 10, 2020

bors commented May 10, 2020

Dylan-DPC-zz commented May 10, 2020

bors commented May 10, 2020

Dylan-DPC-zz commented May 10, 2020

bors commented May 10, 2020

bors commented May 11, 2020

add codegen option strip #71825

add codegen option strip #71825

Conversation

contrun commented May 3, 2020 • edited Loading

rust-highfive commented May 3, 2020

GabrielMajeri commented May 3, 2020

contrun commented May 3, 2020

This comment has been minimized.

josephlr left a comment

Choose a reason for hiding this comment

josephlr May 5, 2020

Choose a reason for hiding this comment

contrun May 5, 2020

Choose a reason for hiding this comment

petrochenkov commented May 5, 2020

cramertj commented May 8, 2020

petrochenkov commented May 8, 2020

petrochenkov commented May 8, 2020

petrochenkov commented May 8, 2020 • edited Loading

tesuji commented May 9, 2020

mati865 commented May 9, 2020

This comment has been minimized.

This comment has been minimized.

petrochenkov commented May 10, 2020

petrochenkov commented May 10, 2020

bors commented May 10, 2020

bors commented May 10, 2020

Dylan-DPC-zz commented May 10, 2020

bors commented May 10, 2020

Dylan-DPC-zz commented May 10, 2020

bors commented May 10, 2020

Dylan-DPC-zz commented May 10, 2020

bors commented May 10, 2020

bors commented May 11, 2020

contrun commented May 3, 2020 •

edited

Loading

petrochenkov commented May 8, 2020 •

edited

Loading