Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better method call error messages #71827

Closed
wants to merge 21 commits into from
Closed

Better method call error messages #71827

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
acd679c
Initial implementation for 65853
Quantumplation May 3, 2020
c266c4c
Adds some basic test cases
Quantumplation May 3, 2020
7fc8e3c
Rust cleanup
Quantumplation May 3, 2020
5bf45b3
Prevent an ICE on empty params
Quantumplation Dec 31, 2020
f1916fa
Interpolate correct types into error messages
Quantumplation Jan 13, 2021
ae3c859
Fix a comment typo
Quantumplation Jan 13, 2021
93ee0af
Small tweaks / typos fixed from code review
Quantumplation Jan 14, 2021
f369af6
Add a ton of test cases, refine error messages
Quantumplation Jan 14, 2021
74faf96
Refactor final_arg_types to use a presized array
Quantumplation Jan 15, 2021
d455267
Remove an if clause that wasn't neccesary
Quantumplation Jan 15, 2021
d570d59
Make the fn_name more nuanced
Quantumplation Jan 15, 2021
6eb1da0
Fixed a bug related to invalid arguments
Quantumplation Jan 15, 2021
ddb50d3
Corrects the spans and types for the Invalid case
Quantumplation Jan 15, 2021
b8c651f
A fix for a &str type check, and a pass at extra span alignment
Quantumplation Jan 15, 2021
28b5a1f
Add a multipart_suggestion_verbose
Jan 16, 2021
552583c
Give preference to latter commas
Jan 17, 2021
de1a6c8
Another round of improvements on spans
Jan 17, 2021
807f656
Refactor the check code to simplify the suggestions.
Jan 19, 2021
c3dea90
Add back error span labels
Quantumplation Feb 6, 2021
1d6bab0
Linting and formatting fixes
Quantumplation Feb 6, 2021
5267285
--bless error messages
Quantumplation Feb 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading