Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some regression tests #71952

Merged
merged 4 commits into from
May 7, 2020
Merged

Add some regression tests #71952

merged 4 commits into from
May 7, 2020

Conversation

JohnTitor
Copy link
Member

Closes #29988
Closes #34979
Pick up two snippets that have been fixed from #67945 (shouldn't be closed yet!)

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 7, 2020

📌 Commit f22bc7b has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
Add some regression tests

Closes rust-lang#29988
Closes rust-lang#34979
Pick up two snippets that have been fixed from rust-lang#67945 (shouldn't be closed yet!)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
Add some regression tests

Closes rust-lang#29988
Closes rust-lang#34979
Pick up two snippets that have been fixed from rust-lang#67945 (shouldn't be closed yet!)
@RalfJung
Copy link
Member

RalfJung commented May 7, 2020

I think this failed on Windows in #71978.

@JohnTitor
Copy link
Member Author

Indeed! @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2020
@JohnTitor
Copy link
Member Author

d717e55 should avoid failures.
@bors r=Dylan-DPC

@bors
Copy link
Contributor

bors commented May 7, 2020

📌 Commit d717e55 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#71938 (Use trait_object_dummy_self instead of err)
 - rust-lang#71952 (Add some regression tests)
 - rust-lang#71959 (tests: Fix warnings in `rust_test_helpers.c`)
 - rust-lang#71962 (Grammar)
 - rust-lang#71972 (use hex for pointers in Miri error messages)
 - rust-lang#71980 (Allow a few warnings.)

Failed merges:

r? @ghost
@bors bors merged commit 480f718 into rust-lang:master May 7, 2020
@JohnTitor JohnTitor deleted the add-tests branch May 7, 2020 20:07
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 13, 2022
…rrors

Add some more regression tests for rust-lang#67945

Closes rust-lang#67945, added two tests from rust-lang#67945 (comment), other snippets were already added in rust-lang#71952 and rust-lang#77439
r? `@compiler-errors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Type annotations needed" with mixed lifetimes in trait bounds FFI calls may create out-of-bounds loads
6 participants