use require_lang_item over unwrap.
#72170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
May 13, 2020
RalfJung
reviewed
May 13, 2020
RalfJung
reviewed
May 13, 2020
|
Could you also cover the one that the issue was reported about? rust/src/librustc_typeck/check/demand.rs Line 637 in 3fe4dd2 |
|
done |
RalfJung
approved these changes
May 14, 2020
There was a problem hiding this comment.
This LGTM. However, this is code that I am not familiar with, so I'd prefer if someone else also took a look. Cc @oli-obk @matthewjasper
|
Oh, that's a very good idea. I wonder if we can make But we can address this in future work. For now: @bors r+ |
|
📌 Commit 9001a64 has been approved by |
bors
added
S-waiting-on-bors
|
This looks like a good |
|
@jonas-schievink Opened #72195 for this, not |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#71910 (Fix unused_parens false positive when using binary operations) - rust-lang#72087 (Fix hang in lexical_region_resolve) - rust-lang#72126 (Change `WorkProduct::saved_files` to an `Option`.) - rust-lang#72127 (add long error explanation for E0228) - rust-lang#72141 (Warn against thread::sleep in async fn) - rust-lang#72170 (use `require_lang_item` over `unwrap`.) - rust-lang#72191 (Clean up E0589 explanation) - rust-lang#72194 (Don't ICE on missing `Unsize` impl) Failed merges: r? @ghost
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
Remove `lang_items\(\).*\.unwrap\(\)` Follows up rust-lang#72170 to remove the remaining uses of `lang_items\(\).*\.unwrap\(\)` (avoids a bunch of potential ICEs when working in `#![no_core]`). Resolves rust-lang#72195
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
Remove `lang_items\(\).*\.unwrap\(\)` Follows up rust-lang#72170 to remove the remaining uses of `lang_items\(\).*\.unwrap\(\)` (avoids a bunch of potential ICEs when working in `#![no_core]`). Resolves rust-lang#72195
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
Remove `lang_items\(\).*\.unwrap\(\)` Follows up rust-lang#72170 to remove the remaining uses of `lang_items\(\).*\.unwrap\(\)` (avoids a bunch of potential ICEs when working in `#![no_core]`). Resolves rust-lang#72195
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 15, 2020
Remove `lang_items\(\).*\.unwrap\(\)` Follows up rust-lang#72170 to remove the remaining uses of `lang_items\(\).*\.unwrap\(\)` (avoids a bunch of potential ICEs when working in `#![no_core]`). Resolves rust-lang#72195
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 16, 2020
Remove `lang_items\(\).*\.unwrap\(\)` Follows up rust-lang#72170 to remove the remaining uses of `lang_items\(\).*\.unwrap\(\)` (avoids a bunch of potential ICEs when working in `#![no_core]`). Resolves rust-lang#72195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not yet replace all uses of
lang_items\(\)\.*\.unwrap\(\), as there are morethan I expected 😅
Fixes #72099
r? @RalfJung
edit: The goal of this this PR is to change ICE from missing lang items to a fatal error.