-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #72276
Rollup of 5 pull requests #72276
Commits on May 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e734e31 - Browse repository at this point
Copy the full SHA e734e31View commit details -
expand "incomplete feature" message to include unsoundness and link t…
…o tracking issue
Configuration menu - View commit details
-
Copy full SHA for 1fce203 - Browse repository at this point
Copy the full SHA 1fce203View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a8cf4a - Browse repository at this point
Copy the full SHA 6a8cf4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb6a6e0 - Browse repository at this point
Copy the full SHA bb6a6e0View commit details
Commits on May 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 00dcb66 - Browse repository at this point
Copy the full SHA 00dcb66View commit details
Commits on May 13, 2020
-
Unified
unescape_{char,byte,str,byte_str,raw_str,raw_byte_str}
meth……ods into one method `unescape_literal` with a mode argument.
Configuration menu - View commit details
-
Copy full SHA for 1be5d1e - Browse repository at this point
Copy the full SHA 1be5d1eView commit details -
Unified
validate_{byte,str,raw_str,raw_byte_str}_escape
methods int……o one method `validate_literal_escape` with a mode argument. This enables simplifying the `match` in `cook_lexer_literal()` and it eliminates 90 lines of repetition :)
Configuration menu - View commit details
-
Copy full SHA for 18cc63d - Browse repository at this point
Copy the full SHA 18cc63dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43ae785 - Browse repository at this point
Copy the full SHA 43ae785View commit details
Commits on May 16, 2020
-
Remove redundant backtick in error message.
The value passed in already has backticks surrounding the text.
Configuration menu - View commit details
-
Copy full SHA for 004f4f3 - Browse repository at this point
Copy the full SHA 004f4f3View commit details -
Rollup merge of rust-lang#72045 - RalfJung:incomplete-unsound, r=petr…
…ochenkov Incomplete features can also be unsound Some incomplete features do not just ICE, they are also currently unsound (e.g. rust-lang#72029, and also `specialization` -- which is not yet marked incomplete but [should be](rust-lang#71420)). This makes the message reflect that. While at it I also added a link to the tracking issue, which hopefully should explain what is incomplete/unsound about the feature.
Configuration menu - View commit details
-
Copy full SHA for aecab5e - Browse repository at this point
Copy the full SHA aecab5eView commit details -
Rollup merge of rust-lang#72047 - Julian-Wollersberger:literal_error_…
…reporting_cleanup, r=petrochenkov Literal error reporting cleanup While doing some performance work, I noticed some code duplication in `librustc_parser/lexer/mod.rs`, so I cleaned it up. This PR is probably best reviewed commit by commit. I'm not sure what the API stability practices for `librustc_lexer` are. Four public methods in `unescape.rs` can be removed, but two are used by clippy, so I left them in for now. I could open a PR for Rust-Analyzer when this one lands. But how do I open a PR for clippy? (Git submodules are frustrating to work with)
Configuration menu - View commit details
-
Copy full SHA for ec5610f - Browse repository at this point
Copy the full SHA ec5610fView commit details -
Rollup merge of rust-lang#72060 - lcnr:move-list, r=estebank
move `ty::List` into a new submodule `rustc_middle/ty` is currently right below the 3000 lines tidy file length limit. Moves `rustc_middle::ty::List` to the private module `rustc_middle::ty::list` and adds a `pub use self::list::List` at its previous location.
Configuration menu - View commit details
-
Copy full SHA for ae66c62 - Browse repository at this point
Copy the full SHA ae66c62View commit details -
Rollup merge of rust-lang#72094 - petrochenkov:overfeature, r=nikic
cmdline: Make target features individually overridable Fixes rust-lang#56527 Previously `-C target-feature=+avx2 -C target-feature=+fma` was equivalent to `-C target-feature=+fma` because the later `-C target-feature` option fully overridden previous `-C target-feature`. With this PR `-C target-feature=+avx2 -C target-feature=+fma` is equivalent to `-C target-feature=+avx2,+fma` and the options are combined. I'm not sure where the comma-separated features in a single option came from (clang uses a scheme with single feature per-option), but logically these features are entirely independent options. So they should be overridable individually as well to be more useful in hierarchical build system, and more consistent with other rustc options and clang behavior as well. Target feature options have a few other issues (rust-lang#44815), but fixing those is going to be a bit more invasive.
Configuration menu - View commit details
-
Copy full SHA for 4fe6d52 - Browse repository at this point
Copy the full SHA 4fe6d52View commit details -
Rollup merge of rust-lang#72254 - ehuss:double-backtick, r=dtolnay
Remove redundant backtick in error message. The value passed in already has backticks surrounding the text.
Configuration menu - View commit details
-
Copy full SHA for 12112f4 - Browse repository at this point
Copy the full SHA 12112f4View commit details