Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #72276

Merged
merged 14 commits into from
May 16, 2020
Merged

Rollup of 5 pull requests #72276

merged 14 commits into from
May 16, 2020

Commits on May 9, 2020

  1. Small doc improvements.

    The phrasing is from the commit description of 395ee0b by @matklad.
    Julian-Wollersberger committed May 9, 2020
    Configuration menu
    Copy the full SHA
    e734e31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1fce203 View commit details
    Browse the repository at this point in the history
  3. adjust tests

    RalfJung committed May 9, 2020
    Configuration menu
    Copy the full SHA
    6a8cf4a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb6a6e0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. Configuration menu
    Copy the full SHA
    00dcb66 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Unified unescape_{char,byte,str,byte_str,raw_str,raw_byte_str} meth…

    …ods into one method `unescape_literal` with a mode argument.
    Julian-Wollersberger committed May 13, 2020
    Configuration menu
    Copy the full SHA
    1be5d1e View commit details
    Browse the repository at this point in the history
  2. Unified validate_{byte,str,raw_str,raw_byte_str}_escape methods int…

    …o one method `validate_literal_escape` with a mode argument.
    
    This enables simplifying the `match` in `cook_lexer_literal()`
    and it eliminates 90 lines of repetition :)
    Julian-Wollersberger committed May 13, 2020
    Configuration menu
    Copy the full SHA
    18cc63d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    43ae785 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Remove redundant backtick in error message.

    The value passed in already has backticks surrounding the text.
    ehuss committed May 16, 2020
    Configuration menu
    Copy the full SHA
    004f4f3 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#72045 - RalfJung:incomplete-unsound, r=petr…

    …ochenkov
    
    Incomplete features can also be unsound
    
    Some incomplete features do not just ICE, they are also currently unsound (e.g. rust-lang#72029, and also `specialization` -- which is not yet marked incomplete but [should be](rust-lang#71420)). This makes the message reflect that.
    
    While at it I also added a link to the tracking issue, which hopefully should explain what is incomplete/unsound about the feature.
    RalfJung authored May 16, 2020
    Configuration menu
    Copy the full SHA
    aecab5e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#72047 - Julian-Wollersberger:literal_error_…

    …reporting_cleanup, r=petrochenkov
    
    Literal error reporting cleanup
    
    While doing some performance work, I noticed some code duplication in `librustc_parser/lexer/mod.rs`, so I cleaned it up.
    
    This PR is probably best reviewed commit by commit.
    
    I'm not sure what the API stability practices for `librustc_lexer` are. Four public methods in `unescape.rs` can be removed, but two are used by clippy, so I left them in for now.
    I could open a PR for Rust-Analyzer when this one lands.
    
    But how do I open a PR for clippy? (Git submodules are frustrating to work with)
    RalfJung authored May 16, 2020
    Configuration menu
    Copy the full SHA
    ec5610f View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#72060 - lcnr:move-list, r=estebank

    move `ty::List` into a new submodule
    
    `rustc_middle/ty` is currently right below the 3000 lines tidy file length limit.
    
    Moves `rustc_middle::ty::List` to the private module `rustc_middle::ty::list` and adds
    a `pub use self::list::List` at its previous location.
    RalfJung authored May 16, 2020
    Configuration menu
    Copy the full SHA
    ae66c62 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72094 - petrochenkov:overfeature, r=nikic

    cmdline: Make target features individually overridable
    
    Fixes rust-lang#56527
    
    Previously `-C target-feature=+avx2 -C target-feature=+fma` was equivalent to `-C target-feature=+fma` because the later `-C target-feature` option fully overridden previous `-C target-feature`.
    With this PR `-C target-feature=+avx2 -C target-feature=+fma` is equivalent to `-C target-feature=+avx2,+fma` and the options are combined.
    
    I'm not sure where the comma-separated features in a single option came from (clang uses a scheme with single feature per-option), but logically these features are entirely independent options.
    So they should be overridable individually as well to be more useful in hierarchical build system, and more consistent with other rustc options and clang behavior as well.
    
    Target feature options have a few other issues (rust-lang#44815), but fixing those is going to be a bit more invasive.
    RalfJung authored May 16, 2020
    Configuration menu
    Copy the full SHA
    4fe6d52 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#72254 - ehuss:double-backtick, r=dtolnay

    Remove redundant backtick in error message.
    
    The value passed in already has backticks surrounding the text.
    RalfJung authored May 16, 2020
    Configuration menu
    Copy the full SHA
    12112f4 View commit details
    Browse the repository at this point in the history