Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Step for char (make Range*<char> iterable) #72413

Merged
merged 5 commits into from
May 30, 2020
Merged

impl Step for char (make Range*<char> iterable) #72413

merged 5 commits into from
May 30, 2020

Commits on May 21, 2020

  1. impl Step for char 

    Enables Range<char> to be iterable

Note: https://rust.godbolt.org/z/fdveKo
An iteration over all char ('\0'..=char::MAX)
includes unreachable panic code currently.
Updating RangeInclusive::next to call
Step::forward_unchecked (which is safe to do
but not done yet becuase it wasn't necessary)
successfully removes the panic from this iteration.
    @CAD97
    CAD97 committed May 21, 2020
    Configuration menu
    Copy the full SHA
    96f3879 View commit details
    Browse the repository at this point in the history

  2. Use Step::forward_unchecked in RangeInclusive::next

    @CAD97
    CAD97 committed May 21, 2020
    Configuration menu
    Copy the full SHA
    c25b82f View commit details
    Browse the repository at this point in the history

  3. Add safety annotations in iter::range

    @CAD97
    CAD97 committed May 21, 2020
    Configuration menu
    Copy the full SHA
    27d1cd8 View commit details
    Browse the repository at this point in the history

  4. Add a test for char ranges

    @CAD97
    CAD97 committed May 21, 2020
    Configuration menu
    Copy the full SHA
    b1d1f25 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. FIx off-by-one in char::steps_between

    @CAD97
    CAD97 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    cd6a8ca View commit details
    Browse the repository at this point in the history