Added io forwarding methods to the stdio structs #72705

Lucretiel · 2020-05-28T19:05:21Z

Added methods to forward the io::Read and io::Write methods of the myriad wrapper structs in stdio.rs to their underlying readers / writers. This is especially important for the structs on the outside of a locking boundary, to ensure that the lock isn't being dropped and re-acquired in a loop.

rust-highfive · 2020-05-28T19:05:24Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-05-28T20:24:48Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 15'
Agent machine name: 'fv-az578'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200517.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200517.1/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.2)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/586a188b-c446-4fb0-aaf9-bd281fcbdcdb.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72705/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72705/merge:refs/remotes/pull/72705/merge
---
 ---> cb2676f08729
Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
 ---> Using cache
 ---> df25ce111862
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
 ---> 599b9ac96b27
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
 ---> Using cache
 ---> 091087e35a36
---
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.10.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.10.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
..............................................................................i..................... 1800/10249
.................................................................................................... 1900/10249
.................................................................................................i.. 2000/10249
i................................................................................................... 2100/10249
.......................................................................................iiiii........ 2200/10249
.................................................................................................... 2400/10249
.................................................................................................... 2500/10249
.................................................................................................... 2600/10249
.................................................................................................... 2700/10249
---
...............i...............i.................................................................... 5200/10249
.................................................................................................... 5300/10249
...............................................................i.................................... 5400/10249
........................................................i........................................... 5500/10249
....................................................................ii.ii........i...i.............. 5600/10249
...........i........................................................................................ 5800/10249
...................i................................................................................ 5900/10249
........................................................................ii.......................... 6000/10249
...........i........................................................................................ 6100/10249
...........i........................................................................................ 6100/10249
.................................................................................................... 6200/10249
.................................................................................................... 6300/10249
.................................ii...i..ii...........i............................................. 6400/10249
.................................................................................................... 6600/10249
.................................................................................................... 6700/10249
.................................................................................................... 6700/10249
..................................................................i..ii............................. 6800/10249
.................................................................................................... 7000/10249
.................................................................................................... 7100/10249
....................i............................................................................... 7200/10249
.................................................................................................... 7300/10249
---
.................................................................................................... 8200/10249
.................................................................................................... 8300/10249
.......................................................i............................................ 8400/10249
.................................................................................................... 8500/10249
.........iiiiii.iiiiii.i............................................................................ 8600/10249
.................................................................................................... 8800/10249
.................................................................................................... 8900/10249
.................................................................................................... 9000/10249
.................................................................................................... 9100/10249
---
status: exit code: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-23781/a"
stdout:
------------------------------------------
<Foo as Debug>::fmt()

------------------------------------------
stderr:
------------------------------------------
------------------------------------------
thread 'main' panicked at 'already borrowed: BorrowMutError', /checkout/src/libcore/cell.rs:877:9

------------------------------------------


---
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-8/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "8.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
Build completed unsuccessfully in 0:57:58
Build completed unsuccessfully in 0:57:58
== clock drift check ==
  local time: Thu May 28 20:24:43 UTC 2020
  network time: Thu, 28 May 2020 20:24:43 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72705/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72705/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3566) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Lucretiel · 2020-05-28T20:44:47Z

I'm not sure how to diagnose that error; it doesn't seem to be related to this change? I guess it could be a reentrant Mutex thing? But I'm not sure how it wouldn't have been failing before.

crlf0710 · 2020-06-05T12:22:28Z

@Lucretiel Ping from triage! It seems like an error from a RefCell. Could you try to reproduce that error locally? Usually the backtrace will help.

I'm also reassigning this to t-libs and applying the libs-impl tag.

r? @Amanieu

Lucretiel · 2020-06-05T20:46:25Z

I'm not sure how to reproduce; the only development machine I have access to right now is a Windows machine, and I'm further not sure where to even begin on a failure that only appears on half the Ubuntu test machines.

Amanieu · 2020-06-05T22:49:57Z

I got a backtrace, here is the relevant part:

   9: core::result::unwrap_failed
  10: <std::io::stdio::Stdout as std::io::Write>::write_fmt
  11: std::io::stdio::print_to
  12: std::io::stdio::_print
  13: <issue_23781::Foo as core::fmt::Debug>::fmt
  14: core::fmt::write
  15: std::io::Write::write_fmt
  16: <std::io::stdio::Stdout as std::io::Write>::write_fmt
  17: std::io::stdio::print_to
  18: std::io::stdio::_print
  19: issue_23781::test2
  20: issue_23781::main

The issue is that the test is calling println! from the Debug impl, which breaks because write_fmt is holding the RefCell lock for the entire duration of the write_fmt call.

Lucretiel · 2020-06-06T15:10:19Z

Thank you! I'll check it out this weekend. Would the possibility of code like this in the wild make this a breaking change?

Amanieu · 2020-06-06T17:08:46Z

I do think this would be a breaking change.

JohnCSimon · 2020-06-16T05:04:28Z

Ping from triage:
@Lucretiel can you please post your status on this PR?

Lucretiel · 2020-06-16T18:49:03Z

Sorry, been busy with other things. I'm still trying to follow the stack trace to track down the panic.

rust-highfive · 2020-06-17T23:09:54Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 6'
Agent machine name: 'fv-az578'
Current agent version: '2.170.1'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200604.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200604.1/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.3)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/89b5581b-610e-48af-b01b-aec603a6bf57.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72705/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72705/merge:refs/remotes/pull/72705/merge
---
 ---> 38c164126245
Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
 ---> Using cache
 ---> afe0ff39f7ee
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
 ---> 45ef90c713f0
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
 ---> Using cache
 ---> d9e5bf90d143
---
   Compiling rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.10.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
   Compiling rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.10.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
.................................................................................................... 1900/10319
.................................................................................................... 2000/10319
...............i..i................................................................................. 2100/10319
.................................................................................................... 2200/10319
.....iiiii.......................................................................................... 2300/10319
.................................................................................................... 2500/10319
.................................................................................................... 2600/10319
.................................................................................................... 2700/10319
.................................................................................................... 2800/10319
---
.................................................................................................... 6000/10319
.......ii.....................................i..................................................... 6100/10319
.................................................................................................... 6200/10319
.................................................................................................... 6300/10319
......................................................................ii...i..ii...........i........ 6400/10319
.................................................................................................... 6600/10319
.................................................................................................... 6700/10319
.................................................................................................... 6800/10319
.................................................................................................... 6800/10319
....i..ii........................................................................................... 6900/10319
.................................................................................................... 7100/10319
...........................................................i........................................ 7200/10319
.................................................................................................... 7300/10319
.................................................................................................... 7400/10319
---
.................................................................................................... 8200/10319
.................................................................................................... 8300/10319
.................................................................................................... 8400/10319
..i................................................................................................. 8500/10319
........................................................iiiiiiiiiiii.i.............................. 8600/10319
............i....................................................................................... 8800/10319
.................................................................................................... 8900/10319
.................................................................................................... 9000/10319
.................................................................................................... 9100/10319
---
------------------------------------------
stderr:
------------------------------------------
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `"212121212"`,
 right: `"22222"`', /checkout/src/test/ui/atomic-print.rs:41:24

------------------------------------------


---
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-8/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "8.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
Build completed unsuccessfully in 1:07:46
Build completed unsuccessfully in 1:07:46
== clock drift check ==
  local time: Wed Jun 17 23:09:48 UTC 2020
  network time: Wed, 17 Jun 2020 23:09:48 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72705/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72705/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (4014) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Lucretiel · 2020-06-18T00:36:38Z

It seems like the only way for this error condition to be triggered is through write_fmt, since write_fmt executes arbitrary user code (which might recursively print!). I've therefore reverted the forwarding versions of those. Everything else hopefully is fine.

Amanieu · 2020-06-18T07:26:35Z

@bors r+

bors · 2020-06-18T07:26:37Z

📌 Commit 14d385b has been approved by Amanieu

Added io forwarding methods to the stdio structs Added methods to forward the `io::Read` and `io::Write` methods of the myriad wrapper structs in `stdio.rs` to their underlying readers / writers. This is especially important for the structs on the outside of a locking boundary, to ensure that the lock isn't being dropped and re-acquired in a loop.

bors · 2020-06-28T01:56:40Z

⌛ Testing commit 14d385b with merge 9ac1ca2ee0af95181b62ee71d9d58fa71812d2fb...

Added io forwarding methods to the stdio structs Added methods to forward the `io::Read` and `io::Write` methods of the myriad wrapper structs in `stdio.rs` to their underlying readers / writers. This is especially important for the structs on the outside of a locking boundary, to ensure that the lock isn't being dropped and re-acquired in a loop.

Manishearth · 2020-06-28T03:08:46Z

@bors r-

Manishearth · 2020-06-28T03:09:32Z

@bors r=Amanieu

(yielding to rollup, bors yield is broken for some reason. this PR is included in the rollup)

bors · 2020-06-28T03:09:32Z

📌 Commit 14d385b has been approved by Amanieu

bors · 2020-06-28T04:16:59Z

⌛ Testing commit 14d385b with merge 3b4a3d6...

bors · 2020-06-28T08:26:15Z

☀️ Test successful - checks-azure
Approved by: Amanieu
Pushing 3b4a3d6 to master...

mati865 · 2020-06-29T17:28:05Z

False positive perf regression is another case of rust-lang/compiler-team#281

Added io forwarding methods to the stdio structs

358dc1d

rust-highfive assigned cramertj May 28, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2020

rust-highfive assigned Amanieu and unassigned cramertj Jun 5, 2020

Removed write_fmt forwarding, to fix recursive borrow issues

b60cefe

Restore some write_fmts

14d385b

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2020

Manishearth mentioned this pull request Jun 18, 2020

Rollup of 17 pull requests #73475

Closed

Manishearth mentioned this pull request Jun 27, 2020

Rollup of 7 pull requests #73790

Closed

Dylan-DPC-zz mentioned this pull request Jun 27, 2020

Rollup of 7 pull requests #73821

Closed

Dylan-DPC-zz mentioned this pull request Jun 28, 2020

Rollup of 8 pull requests #73823

Closed

Manishearth mentioned this pull request Jun 28, 2020

Rollup of 10 pull requests #73824

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 28, 2020

Manishearth closed this Jun 28, 2020

Manishearth reopened this Jun 28, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 28, 2020

bors merged commit 3b4a3d6 into rust-lang:master Jun 28, 2020

bors mentioned this pull request Jun 28, 2020

[WIP] Add set_nonblocking method on Stdin #73343

Closed

Lucretiel mentioned this pull request Jul 14, 2020

Substantial refactor to the design of LineWriter #72808

Merged

Lucretiel deleted the stdio-forwarding branch October 30, 2020 01:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added io forwarding methods to the stdio structs #72705

Added io forwarding methods to the stdio structs #72705

Lucretiel commented May 28, 2020

rust-highfive commented May 28, 2020

rust-highfive commented May 28, 2020

Lucretiel commented May 28, 2020

crlf0710 commented Jun 5, 2020

Lucretiel commented Jun 5, 2020

Amanieu commented Jun 5, 2020

Lucretiel commented Jun 6, 2020

Amanieu commented Jun 6, 2020

JohnCSimon commented Jun 16, 2020

Lucretiel commented Jun 16, 2020

rust-highfive commented Jun 17, 2020

Lucretiel commented Jun 18, 2020

Amanieu commented Jun 18, 2020

bors commented Jun 18, 2020

bors commented Jun 28, 2020

Manishearth commented Jun 28, 2020

Manishearth commented Jun 28, 2020

bors commented Jun 28, 2020

bors commented Jun 28, 2020

bors commented Jun 28, 2020

mati865 commented Jun 29, 2020

Added io forwarding methods to the stdio structs #72705

Added io forwarding methods to the stdio structs #72705

Conversation

Lucretiel commented May 28, 2020

rust-highfive commented May 28, 2020

rust-highfive commented May 28, 2020

Lucretiel commented May 28, 2020

crlf0710 commented Jun 5, 2020

Lucretiel commented Jun 5, 2020

Amanieu commented Jun 5, 2020

Lucretiel commented Jun 6, 2020

Amanieu commented Jun 6, 2020

JohnCSimon commented Jun 16, 2020

Lucretiel commented Jun 16, 2020

rust-highfive commented Jun 17, 2020

Lucretiel commented Jun 18, 2020

Amanieu commented Jun 18, 2020

bors commented Jun 18, 2020

bors commented Jun 28, 2020

Manishearth commented Jun 28, 2020

Manishearth commented Jun 28, 2020

bors commented Jun 28, 2020

bors commented Jun 28, 2020

bors commented Jun 28, 2020

mati865 commented Jun 29, 2020