Add a test to ensure Fuse stays covariant #72902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit a3344d1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72704 (Remote testing fixes) - rust-lang#72820 (InstCombine: Don't optimize `&mut *x` into `x`) - rust-lang#72848 (Correct generic parameter ordering in error note for E0747) - rust-lang#72902 (Add a test to ensure Fuse stays covariant) - rust-lang#72921 (Add assert to Vec with_capacity docs) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #70502 attempted to specialize the data types in
Fuse, one of the problems we found was that it broke variance. This was also realized whenFusewas first added, #35656 (diff), but now this PR adds a test so we don't forget again.