Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first stage of implementing LLVM code coverage #73011

Merged
merged 17 commits into from
Jun 19, 2020
Merged

first stage of implementing LLVM code coverage #73011

merged 17 commits into from
Jun 19, 2020

Commits on May 22, 2020

  1. Merge pull request #1 from rust-lang/master 

    update from upstream
    @richkadel
    richkadel authored May 22, 2020
    Configuration menu
    Copy the full SHA
    a6127e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Merge pull request #2 from rust-lang/master 

    update from origin 2020-06-10
    @richkadel
    richkadel authored Jun 10, 2020
    Configuration menu
    Copy the full SHA
    d139a72 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Merge pull request #3 from rust-lang/master 

    update from origin 2020-06-15
    @richkadel
    richkadel authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    395256a View commit details
    Browse the repository at this point in the history

  2. [WIP] injects llvm intrinsic instrprof.increment for coverage reports 

    This initial version only injects counters at the top of each function.
Rust Coverage will require injecting additional counters at each
conditional code branch.
    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    5068ae1 View commit details
    Browse the repository at this point in the history

  3. explained lang_item function body (count_code_region)

    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    088037a View commit details
    Browse the repository at this point in the history

  4. removed experiments for cleaner github PR

    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    2c5c2a6 View commit details
    Browse the repository at this point in the history

  5. Add case for count_code_region() extern lang_item 

    As suggested in PR feedback:

rust-lang#73011 (comment)

This allows count_code_region() to be handled like a normal intrinsic so
the InstanceDef::InjectedCode variant is no longer needed.
    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    d2cd59a View commit details
    Browse the repository at this point in the history

  6. Update src/libcore/intrinsics.rs 

    Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
    @richkadel @bjorn3
    richkadel and bjorn3 committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e4df7e7 View commit details
    Browse the repository at this point in the history

  7. moved to post_borrowck_cleanup & used MirPatch

    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    7e49a9e View commit details
    Browse the repository at this point in the history

  8. moved instrument_coverage pass, optimized scalar, added FIXME

    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    46ebd57 View commit details
    Browse the repository at this point in the history

  9. added test, Operand::const_from_scalar, require_lang_item, & comments 

    Addresses feedback from @oli-obk (Thanks!)
    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    20aba8f View commit details
    Browse the repository at this point in the history

  10. updated mir-opt test due to other recent changes to MIR

    @richkadel
    richkadel committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    163e585 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Add new fn_span to TerminatorKind::Call instance

    @richkadel
    richkadel committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    98685a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Ensure profiling runtime for -Zinstrument-coverage 

    If config.toml `profiler = false`, the test/mir-opt/instrument_coverage
test is ignored. Otherwise, this patch ensures the profiler_runtime is
loaded when -Zinstrument-coverage is enabled. Confirmed that this works
for MacOS.
    @richkadel
    richkadel committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1db44af View commit details
    Browse the repository at this point in the history

  2. Update src/libcore/intrinsics.rs 

    Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
    @richkadel @bjorn3
    richkadel and bjorn3 authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    c338729 View commit details
    Browse the repository at this point in the history

  3. temporarily enable mac and windows tests on bors try 

    testing platform-specific changes
    @richkadel
    richkadel committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    b9f0304 View commit details
    Browse the repository at this point in the history

  4. removed try config to test mac & windows (passed) 

    https://dev.azure.com/rust-lang/rust/_build/results?buildId=32224&view=results
    @richkadel
    richkadel committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    36c9014 View commit details
    Browse the repository at this point in the history