Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Revert "WF-check all ty::Const's, not just array lengths." #73045

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Revert "WF-check all ty::Const's, not just array lengths." #73045

wants to merge 1 commit into from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jun 5, 2020

checking for a perf regression noted in #70107 (comment)

Let's see if this automated revert passes CI before starting perf.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2020
@Mark-Simulacrum
Copy link
Member

@rust-timer queue @bors try

@bors
Copy link
Contributor

bors commented Jun 5, 2020

⌛ Trying commit 26dfd86 with merge 8db9e9bb497ce0b30e28b780f4412393c396d40f...

@bors
Copy link
Contributor

bors commented Jun 6, 2020

☀️ Try build successful - checks-azure
Build commit: 8db9e9bb497ce0b30e28b780f4412393c396d40f (8db9e9bb497ce0b30e28b780f4412393c396d40f)

@jonas-schievink
Copy link
Contributor

@rust-timer queue 8db9e9bb497ce0b30e28b780f4412393c396d40f

@Mark-Simulacrum
Copy link
Member

@rust-timer build 8db9e9bb497ce0b30e28b780f4412393c396d40f

@rust-timer
Copy link
Collaborator

Queued 8db9e9bb497ce0b30e28b780f4412393c396d40f with parent e412475, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (8db9e9bb497ce0b30e28b780f4412393c396d40f): comparison url.

@mark-i-m
Copy link
Member

mark-i-m commented Jun 6, 2020

It looks like reverting this makes very little difference 😅

@lcnr lcnr closed this Jun 7, 2020
@lcnr lcnr deleted the revert-70107-issue68977 branch June 7, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @Mark-Simulacrum @bors @jonas-schievink @rust-timer @mark-i-m @rust-highfive