extend network support for HermitCore #73331

stlankes · 2020-06-13T22:45:33Z

add basic support of TcpListerner for HermitCore
revise TcpStream to support peer_addr

Add basic support of TcpListerner for HermitCore. In addition, revise TcpStream to support peer_addr.

rust-highfive · 2020-06-13T22:45:36Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-06-14T00:38:18Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux mingw-check
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 2'
Agent machine name: 'fv-az619'
Current agent version: '2.170.1'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200604.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200604.1/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.3)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/26f61cda-129e-40f9-9666-cb6395f8edfd.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/73331/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/73331/merge:refs/remotes/pull/73331/merge
---
 ---> f883e675ad62
Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
 ---> Using cache
 ---> c0b156eb069c
Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            python3 ../x.py doc --stage 0 src/libstd &&            /scripts/validate-toolstate.sh
 ---> 8541bab6b38c
Successfully built 8541bab6b38c
Successfully tagged rust-ci:latest
Built container sha256:8541bab6b38c07f1b7eb787539b9cbe93daa6ac4458d3d7bd8a8921622a14ba1
---
    Checking rustc_span v0.0.0 (/checkout/src/librustc_span)
    Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_session v0.0.0 (/checkout/src/librustc_session)
    Checking chalk-solve v0.10.0
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
---
configure: llvm.assertions      := True
configure: rust.codegen-units-std := 1
configure: rust.verify-llvm-ir  := True
configure: rust.debug-assertions := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Hugepagesize:       2048 kB
DirectMap4k:      112576 kB
DirectMap2M:     4081664 kB
DirectMap1G:     5242880 kB
+ python3 ../x.py test src/tools/expand-yaml-anchors
Ensuring the YAML anchors in the GitHub Actions config were expanded
Ensuring the YAML anchors in the GitHub Actions config were expanded
Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.11
   Compiling linked-hash-map v0.5.2
   Compiling lazy_static v1.4.0
   Compiling lazy_static v1.4.0
   Compiling yaml-rust v0.4.3
   Compiling quote v1.0.2
   Compiling thiserror-impl v1.0.5
   Compiling thiserror v1.0.5
   Compiling yaml-merge-keys v0.4.0
   Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
Build completed successfully in 0:00:28
+ python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
    Finished dev [unoptimized] target(s) in 0.16s
Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
    Checking rustc_span v0.0.0 (/checkout/src/librustc_span)
    Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
    Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
    Checking rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_session v0.0.0 (/checkout/src/librustc_session)
    Checking chalk-solve v0.10.0
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
---
 }
 
-
 #[derive(Clone)]
 pub struct TcpStream(Arc<Socket>);
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 158:
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 158:
                     ((addr.0[8] as u16) << 8) | addr.0[9] as u16,
                     ((addr.0[10] as u16) << 8) | addr.0[11] as u16,
                     ((addr.0[12] as u16) << 8) | addr.0[13] as u16,
-                    ((addr.0[14] as u16) << 8) | addr.0[15] as u16)),
+                    ((addr.0[14] as u16) << 8) | addr.0[15] as u16,
+                )),
             ),
             _ => {
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 165:
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 165:
                 return Err(io::Error::new(ErrorKind::Other, "peer_addr failed"));
+            }
         };
 
         Ok(saddr)
         Ok(saddr)
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 249:
                     ((addr.0[8] as u16) << 8) | addr.0[9] as u16,
                     ((addr.0[10] as u16) << 8) | addr.0[11] as u16,
                     ((addr.0[12] as u16) << 8) | addr.0[13] as u16,
-                    ((addr.0[14] as u16) << 8) | addr.0[15] as u16)),
+                    ((addr.0[14] as u16) << 8) | addr.0[15] as u16,
+                )),
             ),
             _ => {
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 256:
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 256:
                 return Err(io::Error::new(ErrorKind::Other, "accept failed"));
+            }
         };
 
 
         Ok((TcpStream(Arc::new(Socket(handle))), saddr))
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/libstd/sys/hermit/net.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
Build completed unsuccessfully in 0:00:43
== clock drift check ==
  local time: Sat Jun 13 23:07:51 UTC 2020
  network time: Sat, 13 Jun 2020 23:07:51 GMT
  network time: Sat, 13 Jun 2020 23:07:51 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/73331/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/73331/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3708) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

src/libstd/sys/hermit/net.rs

rust-highfive · 2020-06-14T23:32:39Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux mingw-check
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 6'
Agent machine name: 'fv-az578'
Current agent version: '2.170.1'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200604.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200604.1/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.3)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/8752bc07-c69d-4d2b-9f5b-f5a95cfe4688.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/73331/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/73331/merge:refs/remotes/pull/73331/merge
---
 ---> f883e675ad62
Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
 ---> Using cache
 ---> c0b156eb069c
Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            python3 ../x.py doc --stage 0 src/libstd &&            /scripts/validate-toolstate.sh
 ---> 8541bab6b38c
Successfully built 8541bab6b38c
Successfully tagged rust-ci:latest
Built container sha256:8541bab6b38c07f1b7eb787539b9cbe93daa6ac4458d3d7bd8a8921622a14ba1
---
    Checking chalk-rust-ir v0.10.0
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_session v0.0.0 (/checkout/src/librustc_session)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
    Checking rustc_ast_passes v0.0.0 (/checkout/src/librustc_ast_passes)
---
configure: build.locked-deps    := True
configure: rust.dist-src        := False
configure: rust.debug-assertions := True
configure: rust.channel         := nightly
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Hugepagesize:       2048 kB
DirectMap4k:      124864 kB
DirectMap2M:     5117952 kB
DirectMap1G:     4194304 kB
+ python3 ../x.py test src/tools/expand-yaml-anchors
Ensuring the YAML anchors in the GitHub Actions config were expanded
Ensuring the YAML anchors in the GitHub Actions config were expanded
Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
   Compiling unicode-xid v0.2.0
   Compiling syn v1.0.11
   Compiling linked-hash-map v0.5.2
   Compiling lazy_static v1.4.0
   Compiling lazy_static v1.4.0
   Compiling yaml-rust v0.4.3
   Compiling quote v1.0.2
   Compiling thiserror-impl v1.0.5
   Compiling thiserror v1.0.5
   Compiling yaml-merge-keys v0.4.0
   Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
Build completed successfully in 0:00:25
+ python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
    Finished dev [unoptimized] target(s) in 0.16s
Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
    Checking rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
    Checking chalk-rust-ir v0.10.0
    Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
    Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
    Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
    Checking chalk-solve v0.10.0
    Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
    Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
    Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
 }
 
-
 #[derive(Clone)]
 pub struct TcpStream(Arc<Socket>);
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 149:
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 149:
                 IpAddr::V4(Ipv4Addr::new(addr.0[0], addr.0[1], addr.0[2], addr.0[3])),
             ),
             ),
-            Ipv6(ref addr) => SocketAddr::new(
-                IpAddr::V6(Ipv6Addr::new(addr.0)),
-            ),
-            ),
+            Ipv6(ref addr) => SocketAddr::new(IpAddr::V6(Ipv6Addr::new(addr.0)), port),
             _ => {
                 return Err(io::Error::new(ErrorKind::Other, "peer_addr failed"));
+            }
         };
 
         Ok(saddr)
         Ok(saddr)
Diff in /checkout/src/libstd/sys/hermit/net.rs at line 232:
                 IpAddr::V4(Ipv4Addr::new(addr.0[0], addr.0[1], addr.0[2], addr.0[3])),
             ),
             ),
-            Ipv6(ref addr) => SocketAddr::new(
-                IpAddr::V6(Ipv6Addr::new(addr.0)),
-            ),
-            ),
+            Ipv6(ref addr) => SocketAddr::new(IpAddr::V6(Ipv6Addr::new(addr.0)), port),
             _ => {
                 return Err(io::Error::new(ErrorKind::Other, "accept failed"));
+            }
         };
 
 
         Ok((TcpStream(Arc::new(Socket(handle))), saddr))
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/libstd/sys/hermit/net.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
Build completed unsuccessfully in 0:00:38
== clock drift check ==
  local time: Sun Jun 14 22:03:20 UTC 2020
  network time: Sun, 14 Jun 2020 22:03:20 GMT
  network time: Sun, 14 Jun 2020 22:03:20 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/73331/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/73331/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3475) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

src/libstd/sys/hermit/net.rs

This reverts commit 9d596b5.

This reverts commit d221ffc.

kennytm · 2020-06-15T08:57:50Z

@bors r+ rollup

bors · 2020-06-15T08:57:52Z

📌 Commit 76f1581 has been approved by kennytm

extend network support for HermitCore - add basic support of TcpListerner for HermitCore - revise TcpStream to support peer_addr

tesuji · 2020-06-15T11:05:09Z

src/libstd/sys/hermit/net.rs

+
+        let saddr = match ipaddr {
+            Ipv4(ref addr) => SocketAddr::new(
+                IpAddr::V4(Ipv4Addr::new(addr.0[0], addr.0[1], addr.0[2], addr.0[3])),


Suggested change

IpAddr::V4(Ipv4Addr::new(addr.0[0], addr.0[1], addr.0[2], addr.0[3])),

IpAddr::V4(Ipv4Addr::from(addr.0)),

Resolving in #73389 .

tesuji · 2020-06-15T11:05:38Z

src/libstd/sys/hermit/net.rs

+            .map_err(|_| io::Error::new(ErrorKind::Other, "accept failed"))?;
+        let saddr = match ipaddr {
+            Ipv4(ref addr) => SocketAddr::new(
+                IpAddr::V4(Ipv4Addr::new(addr.0[0], addr.0[1], addr.0[2], addr.0[3])),


Suggested change

IpAddr::V4(Ipv4Addr::new(addr.0[0], addr.0[1], addr.0[2], addr.0[3])),

IpAddr::V4(Ipv4Addr::from(addr.0)),

@ghost

Rollup of 10 pull requests Successful merges: - rust-lang#72707 (Use min_specialization in the remaining rustc crates) - rust-lang#72740 (On recursive ADT, provide indirection structured suggestion) - rust-lang#72879 (Miri: avoid tracking current location three times) - rust-lang#72938 (Stabilize Option::zip) - rust-lang#73086 (Rename "cyclone" to "apple-a7" per changes in upstream LLVM) - rust-lang#73104 (Example about explicit mutex dropping) - rust-lang#73139 (Add methods to go from a nul-terminated Vec<u8> to a CString) - rust-lang#73296 (Remove vestigial CI job msvc-aux.) - rust-lang#73304 (Revert heterogeneous SocketAddr PartialEq impls) - rust-lang#73331 (extend network support for HermitCore) Failed merges: r? @ghost

Use `Ipv4Addr::from<[u8; 4]>` when possible Resolve this comment: rust-lang#73331 (comment)

stlankes added 3 commits June 13, 2020 20:51

add TcpListener support for HermitCore

71d41d9

Add basic support of TcpListerner for HermitCore. In addition, revise TcpStream to support peer_addr.

remove unused function

c99116a

use latest interface to HermitCore

fd86a84

rust-highfive assigned kennytm Jun 13, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2020

tesuji reviewed Jun 14, 2020

View reviewed changes

src/libstd/sys/hermit/net.rs Outdated Show resolved Hide resolved

tesuji reviewed Jun 14, 2020

View reviewed changes

src/libstd/sys/hermit/net.rs Outdated Show resolved Hide resolved

simplify conversion to IpAddr::V6

d221ffc

stlankes added 2 commits June 15, 2020 07:28

changes to pass the format check

9d596b5

remove obsolete line

810ba39

kennytm reviewed Jun 15, 2020

View reviewed changes

src/libstd/sys/hermit/net.rs Show resolved Hide resolved

stlankes added 5 commits June 15, 2020 08:43

Revert "changes to pass the format check"

aa53a03

This reverts commit 9d596b5.

Revert "simplify conversion to IpAddr::V6"

9c9f21f

This reverts commit d221ffc.

use Ipv6Addr::from to build the IPv6 address

6c983a7

add comment about the usage of Arc

a8e3746

remove obsolete , to pass the format check

76f1581

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2020

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 15, 2020

Rollup merge of rust-lang#73331 - hermitcore:listen, r=kennytm

a4b4a5f

extend network support for HermitCore - add basic support of TcpListerner for HermitCore - revise TcpStream to support peer_addr

This was referenced Jun 15, 2020

Rollup of 10 pull requests #73368

Closed

Rollup of 10 pull requests #73369

Merged

tesuji reviewed Jun 15, 2020

View reviewed changes

bors merged commit 54bd077 into rust-lang:master Jun 15, 2020

tesuji mentioned this pull request Jun 16, 2020

Use Ipv4Addr::from<[u8; 4]> when possible #73389

Merged

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 16, 2020

Rollup merge of rust-lang#73389 - lzutao:from, r=kennytm

176d7eb

Use `Ipv4Addr::from<[u8; 4]>` when possible Resolve this comment: rust-lang#73331 (comment)

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 16, 2020

Rollup merge of rust-lang#73389 - lzutao:from, r=kennytm

3c437e5

Use `Ipv4Addr::from<[u8; 4]>` when possible Resolve this comment: rust-lang#73331 (comment)

dtolnay added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 19, 2020

mkroening deleted the listen branch December 11, 2022 19:09

cuviper added this to the 1.46 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extend network support for HermitCore #73331

extend network support for HermitCore #73331

stlankes commented Jun 13, 2020

rust-highfive commented Jun 13, 2020

rust-highfive commented Jun 14, 2020

rust-highfive commented Jun 14, 2020

kennytm commented Jun 15, 2020

bors commented Jun 15, 2020

tesuji Jun 15, 2020

tesuji Jun 16, 2020

tesuji Jun 15, 2020

	IpAddr::V4(Ipv4Addr::new(addr.0[0], addr.0[1], addr.0[2], addr.0[3])),
	IpAddr::V4(Ipv4Addr::from(addr.0)),

extend network support for HermitCore #73331

extend network support for HermitCore #73331

Conversation

stlankes commented Jun 13, 2020

rust-highfive commented Jun 13, 2020

rust-highfive commented Jun 14, 2020

rust-highfive commented Jun 14, 2020

kennytm commented Jun 15, 2020

bors commented Jun 15, 2020

tesuji Jun 15, 2020

Choose a reason for hiding this comment

tesuji Jun 16, 2020

Choose a reason for hiding this comment

tesuji Jun 15, 2020

Choose a reason for hiding this comment