rustbuild: Move compiler-builtins build logic to manifest #73374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
There will be a few more steps before this can help build-std. The root manifest is not included in the src distribution (rust-lang/wg-cargo-std-aware#27). Even if it was, Cargo would need to merge the profiles somehow (possibly just the overrides?) (cc rust-lang/wg-cargo-std-aware#28). |
|
Oh it's true yeah I don't expect this to "simply by default" help build-std, but at least in this form the information is encoded in a way that build-std has any hope of reading one day! |
|
@bors r+ One thing I've been thinking about is that more broadly, removing support for configuring these values in config.toml may make some sense. On the other hand, it does seem true that it's nice to have the .gitignore'd nature of config.toml which you can't readily get with Cargo.toml today (due to lack of cargo.toml inheritance) as far as I know. |
|
📌 Commit 260d5cf has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 26, 2020
…g-assertions, r=Mark-Simulacrum rustbuild: Move compiler-builtins build logic to manifest This commit moves the compiler-builtins-specific build logic from `src/bootstrap/bin/rustc.rs` into the workspace `Cargo.toml`'s `[profile]` configuration. Now that rust-lang/cargo#7253 is fixed we can ensure that Cargo knows about debug assertions settings, and it can also be configured to specifically disable debug assertions unconditionally for compiler-builtins. This should improve rebuild logic when debug-assertions settings change and also improve build-std integration where Cargo externally now has an avenue to learn how to build compiler-builtins as well.
|
Seeing a failure in #73768 (comment) , might be y'all, but it might also be a bad interaction with a different PR |
|
⌛ Testing commit 260d5cf with merge 3e6c31fa36e8bdd5333aa341f8205bfb3f47ce06... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
This commit moves the compiler-builtins-specific build logic from `src/bootstrap/bin/rustc.rs` into the workspace `Cargo.toml`'s `[profile]` configuration. Now that rust-lang/cargo#7253 is fixed we can ensure that Cargo knows about debug assertions settings, and it can also be configured to specifically disable debug assertions unconditionally for compiler-builtins. This should improve rebuild logic when debug-assertions settings change and also improve build-std integration where Cargo externally now has an avenue to learn how to build compiler-builtins as well.
alexcrichton
force-pushed
the
compiler-bulitins-debug-assertions
branch
from
260d5cf
to
3dfbf0b
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit 3dfbf0b has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 29, 2020
…g-assertions, r=Mark-Simulacrum rustbuild: Move compiler-builtins build logic to manifest This commit moves the compiler-builtins-specific build logic from `src/bootstrap/bin/rustc.rs` into the workspace `Cargo.toml`'s `[profile]` configuration. Now that rust-lang/cargo#7253 is fixed we can ensure that Cargo knows about debug assertions settings, and it can also be configured to specifically disable debug assertions unconditionally for compiler-builtins. This should improve rebuild logic when debug-assertions settings change and also improve build-std integration where Cargo externally now has an avenue to learn how to build compiler-builtins as well.
|
☀️ Test successful - checks-azure |
tmiasko
added a commit
to tmiasko/rust
that referenced
this pull request
Jul 5, 2020
Since rust-lang#73374 the rustc wrapper no longer configures debug assertions based on RUSTC_DEBUG_ASSERTIONS environment variable.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 6, 2020
…alfJung Remove unused RUSTC_DEBUG_ASSERTIONS Since rust-lang#73374 the rustc wrapper no longer configures debug assertions based on RUSTC_DEBUG_ASSERTIONS environment variable. r? @RalfJung
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 6, 2020
…alfJung Remove unused RUSTC_DEBUG_ASSERTIONS Since rust-lang#73374 the rustc wrapper no longer configures debug assertions based on RUSTC_DEBUG_ASSERTIONS environment variable. r? @RalfJung
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jul 6, 2020
…alfJung Remove unused RUSTC_DEBUG_ASSERTIONS Since rust-lang#73374 the rustc wrapper no longer configures debug assertions based on RUSTC_DEBUG_ASSERTIONS environment variable. r? @RalfJung
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 7, 2020
…alfJung Remove unused RUSTC_DEBUG_ASSERTIONS Since rust-lang#73374 the rustc wrapper no longer configures debug assertions based on RUSTC_DEBUG_ASSERTIONS environment variable. r? @RalfJung
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the compiler-builtins-specific build logic from
src/bootstrap/bin/rustc.rsinto the workspaceCargo.toml's[profile]configuration. Now that rust-lang/cargo#7253 is fixed we canensure that Cargo knows about debug assertions settings, and it can also
be configured to specifically disable debug assertions unconditionally
for compiler-builtins. This should improve rebuild logic when
debug-assertions settings change and also improve build-std integration
where Cargo externally now has an avenue to learn how to build
compiler-builtins as well.