Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate fake IDs in ReplaceBodyWithLoop #73532

Closed
wants to merge 4 commits into from
Closed

Don't generate fake IDs in ReplaceBodyWithLoop #73532

wants to merge 4 commits into from

Commits on Jun 20, 2020

  1. Fix -Z unpretty=everybody_loops 

    It turns out that this has not been working for who knows how long.
Previously:

```
pub fn h() { 1 + 2; }
```

After this change:

```
pub fn h() { loop {} }
```

This only affected the pass when run with the command line
pretty-printing option, so rustdoc was still replacing bodies with
`loop {}`.
    @jyn514
    jyn514 committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    6dac78b View commit details
    Browse the repository at this point in the history

  2. Don't generate fake IDs in ReplaceBodyWithLoop

    @jyn514
    jyn514 committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    fd834ee View commit details
    Browse the repository at this point in the history

  3. Cleanup 

    - x.py fmt
- Remove commented-out code
- Change variable names to match usage
- Fix indentation
    @jyn514
    jyn514 committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    e3ab507 View commit details
    Browse the repository at this point in the history

  4. Add rustdoc tests from rust-lang#72088

    @ecstatic-morse @jyn514
    ecstatic-morse authored and jyn514 committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    ab30797 View commit details
    Browse the repository at this point in the history