Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove rustdoc warnings #73548

Merged
merged 1 commit into from
Jul 1, 2020
Merged

remove rustdoc warnings #73548

merged 1 commit into from
Jul 1, 2020

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2020
ecstatic-morse
ecstatic-morse reviewed Jun 22, 2020
View reviewed changes
src/librustc_mir_build/hair/pattern/_match.rs Outdated
//! (a) the patterns cover every possible constructor for the type [exhaustiveness]
//! (b) each pattern is necessary [usefulness]
//! (a) the patterns cover every possible constructor for the type exhaustiveness
//! (b) each pattern is necessary usefulness
Copy link
Contributor

@ecstatic-morse ecstatic-morse Jun 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use parens instead of brackets here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do those signify?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say in this circumstance, the parenthesized word signifies how the word is being used in this context. That is, the phrase preceding the parenthetical is the definition for the word.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I get it now... I thought those words were just continuations of the sentence

@ecstatic-morse
Copy link
Contributor

r=me with nit fixed.

@bors delegate+

@bors
Copy link
Contributor

bors commented Jun 22, 2020

✌️ @tshepang can now approve this pull request

@tshepang
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2020

📌 Commit f3645ca has been approved by tshepang

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2020
@tshepang
Copy link
Member Author

@bors r=ecstatic-morse

@bors
Copy link
Contributor

bors commented Jun 30, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jun 30, 2020

📌 Commit f3645ca has been approved by ecstatic-morse

@tshepang
Copy link
Member Author

@bors r=ecstatic-morse rollup

@bors
Copy link
Contributor

bors commented Jun 30, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jun 30, 2020

📌 Commit f3645ca has been approved by ecstatic-morse

@tshepang
Copy link
Member Author

@ecstatic-morse did I do the approval as you meant?

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 30, 2020
@Manishearth
Rollup merge of rust-lang#73548 - tshepang:fix-rustdoc-warnings, r=ec…
d8f38e9 
…static-morse

remove rustdoc warnings
@Manishearth Manishearth mentioned this pull request Jun 30, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 1, 2020