Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused crate imports in 2018 edition crates #73638

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Remove unused crate imports in 2018 edition crates #73638

merged 1 commit into from
Jun 24, 2020

Conversation

nn1ks
Copy link
Contributor

@nn1ks nn1ks commented Jun 23, 2020

Closes #73570

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2020
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2020

📌 Commit 9267b4f has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2020
@nikomatsakis
Copy link
Contributor

@bors rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 24, 2020
…r=nikomatsakis

Remove unused crate imports in 2018 edition crates

Closes rust-lang#73570
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#73638 (Remove unused crate imports in 2018 edition crates)
 - rust-lang#73639 (Change heuristic for determining range literal)
 - rust-lang#73646 (Add some regression tests)
 - rust-lang#73652 (Add re-exports to use suggestions)
 - rust-lang#73667 (Update BTreeMap::new() doc)
 - rust-lang#73675 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit 38c85b7 into rust-lang:master Jun 24, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused crate imports in 2018 edition crates
5 participants