Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the self keyword #73688

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Document the self keyword #73688

merged 1 commit into from
Jun 25, 2020

Conversation

poliorcetics
Copy link
Contributor

@poliorcetics poliorcetics commented Jun 24, 2020 •
edited
Loading

Partial fix of #34601.

This documents the self keyword, adding several examples and a link to the reference.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2020
@poliorcetics
Copy link
Contributor Author

@rustbot modify labels: T-doc,C-enhancement

@rustbot rustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jun 24, 2020
@poliorcetics poliorcetics mentioned this pull request Jun 24, 2020
Closed
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 24, 2020

📌 Commit 0366163 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 25, 2020
@Dylan-DPC
Rollup merge of rust-lang#73688 - poliorcetics:self-keyword, r=joshtr…
1c9ee63 
…iplett

Document the self keyword

Partial fix of rust-lang#34601.

This documents the `self` keyword, adding several examples and a link to the reference.
This was referenced Jun 25, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 25, 2020
@bors
Auto merge of rust-lang#73711 - Dylan-DPC:rollup-kzx15of, r=Dylan-DPC
9f3c96b 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#72700 (`improper_ctypes_definitions` lint)
 - rust-lang#73516 (Allow dynamic linking for iOS/tvOS targets)
 - rust-lang#73616 (Liballoc minor hash import tweak)
 - rust-lang#73634 (Add UI test for issue 73592)
 - rust-lang#73688 (Document the self keyword)
 - rust-lang#73698 (Add procedure for prioritization notifications on Zulip)

Failed merges:

r? @ghost
@bors bors merged commit a5839f3 into rust-lang:master Jun 25, 2020
@poliorcetics poliorcetics deleted the self-keyword branch June 26, 2020 07:42
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@poliorcetics @rust-highfive @joshtriplett @bors @cuviper @rustbot