Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'tcx for references to AccessLevels wherever possible. #73753

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jun 26, 2020

Most of the changes are just fallout from removing a lifetime parameter from structs, and mostly in clippy.

r? @Manishearth

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2020
@Manishearth
Copy link
Member

r=me, as I understand it the last commit just removes the lifetime parameter from LateContext, yes?

@eddyb
Copy link
Member Author

eddyb commented Jun 26, 2020

@Manishearth Those are the changes in src/librustc_lint and src/tools/clippy, yes. Outside of that there's only a small number of similar lifetime parameter removals (maybe I should've kept them in a separate commit, oh well).
So presumably I can r=you post-#73751.

@bors

This comment has been minimized.

@eddyb eddyb force-pushed the extraneous-lifetime branch 3 times, most recently from a1cce6e to bcdc482 Compare July 2, 2020 15:08
@eddyb eddyb marked this pull request as ready for review July 2, 2020 21:05
@eddyb
Copy link
Member Author

eddyb commented Jul 2, 2020

@bors r=Manishearth

@bors
Copy link
Contributor

bors commented Jul 2, 2020

📌 Commit 874f406 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2020
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#73454 (Move contributing.md to rustc-dev-guide and point at getting started)
 - rust-lang#73724 (Use WASM's saturating casts if they are available)
 - rust-lang#73726 (resolve: disallow labelled breaks/continues through closures/async blocks)
 - rust-lang#73753 (Use 'tcx for references to AccessLevels wherever possible.)
 - rust-lang#73781 (Update psm version)
 - rust-lang#73952 (Add option for local docker testing.)
 - rust-lang#73957 (disable BTree min_max test in Miri for now)
 - rust-lang#73975 (Document rustc_ast::ast::Pat)

Failed merges:

r? @ghost
@bors bors merged commit d6bfca2 into rust-lang:master Jul 3, 2020
@eddyb eddyb deleted the extraneous-lifetime branch July 3, 2020 03:33
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants