Allow for parentheses after macro intra-doc-links #73791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jul 9, 2020
|
Thanks! @bors: r+ |
|
📌 Commit 1ab8260494e31a214ad16a1278855d031698e399 has been approved by |
bors
added
S-waiting-on-bors
|
Shouldn't a test be added for this? |
|
Outch, good catch @ollie27 ! Please add a test @Manishearth. @bors: r- |
bors
added
S-waiting-on-author
|
@ollie27 we mostly don't have tests for this kind of thing, i was considering adding them separately, but i can do that |
Manishearth
force-pushed
the
parens-intra-doc
branch
from
1ab8260
to
08d3a74
Compare
|
I was wrong, we do test this, it was just part of another test. |
jyn514
approved these changes
Jul 9, 2020
|
@bors r=GuillaumeGomez,jyn514 rollup |
|
📌 Commit fe351e9 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 9, 2020
…llaumeGomez,jyn514 Allow for parentheses after macro intra-doc-links None
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 9, 2020
…llaumeGomez,jyn514 Allow for parentheses after macro intra-doc-links None
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 9, 2020
…arth Rollup of 14 pull requests Successful merges: - rust-lang#73292 (Fixing broken link for the Eq trait) - rust-lang#73791 (Allow for parentheses after macro intra-doc-links) - rust-lang#74070 ( Use for<'tcx> fn pointers in Providers, instead of having Providers<'tcx>.) - rust-lang#74077 (Use relative path for local links to primitives) - rust-lang#74079 (Eliminate confusing "globals" terminology.) - rust-lang#74107 (Hide `&mut self` methods from Deref in sidebar if there are no `DerefMut` impl for the type.) - rust-lang#74136 (Fix broken link in rustdocdoc) - rust-lang#74137 (Update cargo) - rust-lang#74142 (Liballoc use vec instead of vector) - rust-lang#74143 (Try remove unneeded ToString import in liballoc slice) - rust-lang#74146 (update miri) - rust-lang#74150 (Avoid "blacklist") - rust-lang#74184 (Add docs for intra-doc-links) - rust-lang#74188 (Tweak `::` -> `:` typo heuristic and reduce verbosity) Failed merges: - rust-lang#74122 (Start-up clean-up) - rust-lang#74127 (Avoid "whitelist") r? @ghost
|
@bors p=5 trying something |
|
@bors p=0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.