Fix try_print_visible_def_path for Rust 2018 #73871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recursive check of `try_print_visible_def_path` did not properly handle the Rust 2018 case of crate-paths without 'extern crate'. Instead, it returned a "not found" via (false, self). This fixes issue rust-lang#56175.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
reviewed
Jul 1, 2020
petrochenkov
added
S-waiting-on-author
petrochenkov
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit f77b6fe has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 4, 2020
…r=petrochenkov Fix try_print_visible_def_path for Rust 2018 The recursive check of `try_print_visible_def_path` did not properly handle the Rust 2018 case of crate-paths without 'extern crate'. Instead, it returned a "not found" via (false, self). This fixes rust-lang#56175.
|
⌛ Testing commit f77b6fe with merge 0a9e1b3b33d7d0b80f9b9e2f11cef39884177e43... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Failed build and no output. Weird. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit f77b6fe with merge 7117d07965f523f754ba0b6834449af1f1a56fa1... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 5, 2020
…r=petrochenkov Fix try_print_visible_def_path for Rust 2018 The recursive check of `try_print_visible_def_path` did not properly handle the Rust 2018 case of crate-paths without 'extern crate'. Instead, it returned a "not found" via (false, self). This fixes rust-lang#56175.
|
⌛ Testing commit f77b6fe with merge a601326f37e5069bbb7b6aa7607f1815ed5c1756... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2020
…arth Rollup of 12 pull requests Successful merges: - rust-lang#72688 (added .collect() into String from Box<str>) - rust-lang#73787 (Add unstable docs for rustc_attrs) - rust-lang#73834 (Some refactoring around intrinsic type checking) - rust-lang#73871 (Fix try_print_visible_def_path for Rust 2018) - rust-lang#73937 (Explain exhaustive matching on {usize,isize} maximum values) - rust-lang#73973 (Use `Span`s to identify unreachable subpatterns in or-patterns) - rust-lang#74000 (add `lazy_normalization_consts` feature gate) - rust-lang#74025 (Remove unnecessary release from Arc::try_unwrap) - rust-lang#74027 (Convert more `DefId`s to `LocalDefId`s) - rust-lang#74055 (Fix spacing in Iterator fold doc) - rust-lang#74057 (expected_found `&T` -> `T`) - rust-lang#74064 (variant_count: avoid incorrect dummy implementation) Failed merges: r? @ghost
|
I believe this PR has caused #74081 backtrace: https://gist.github.com/Mark-Simulacrum/c1fd825658ba202c9d7f8be9293f62bc#file-gistfile1-txt-L39) EDIT: well, I don't know how it could have caused it, but it's the closest thing in the rollup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursive check of
try_print_visible_def_pathdid not properly handle the Rust 2018 case of crate-paths without 'extern crate'. Instead, it returned a "not found" via (false, self).This fixes #56175.