Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up E0718 explanation #74123

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2020
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GuillaumeGomez
Copy link
Member Author

@bors: r=pickfire rollup

@bors
Copy link
Contributor

bors commented Jul 12, 2020

📌 Commit 4728438 has been approved by pickfire

@bors
Copy link
Contributor

bors commented Jul 12, 2020

🌲 The tree is currently closed for pull requests below priority 30, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2020
@pickfire
Copy link
Contributor

@GuillaumeGomez Can I even do rollups? I thought it needs to be authorized users?

@Dylan-DPC-zz
Copy link

@pickfire this just marks it safe for a rollup, you don't have to do the rollup :D

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2020
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#73354 (Update RELEASES.md for 1.45.0)
 - rust-lang#73852 (rustdoc: insert newlines between attributes)
 - rust-lang#73867 (Document the union keyword)
 - rust-lang#74046 (Fix caching issue when building tools.)
 - rust-lang#74123 (clean up E0718 explanation)
 - rust-lang#74147 (rustdoc: Allow linking from private items to private types)
 - rust-lang#74285 (rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics)
 - rust-lang#74286 (Added detailed error code explanation for issue E0688 in Rust compiler.)

Failed merges:

r? @ghost
@bors bors merged commit 549aa03 into rust-lang:master Jul 14, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0718 branch July 14, 2020 14:24
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants