Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] implement Default using const generics #74326

Closed
wants to merge 1 commit into from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 14, 2020

This PR is mostly just checking if using const generics to implement Default for arrays improves compile times.

cc @MikailBag who is implementing this in #74254

r? @ghost

@lcnr
Copy link
Contributor Author

lcnr commented Jul 14, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jul 14, 2020

⌛ Trying commit 329c85d with merge 8e0830658e77454a0c7dd437c75522a6debf9f64...

@bors
Copy link
Contributor

bors commented Jul 14, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 8e0830658e77454a0c7dd437c75522a6debf9f64 (8e0830658e77454a0c7dd437c75522a6debf9f64)

@rust-timer
Copy link
Collaborator

Queued 8e0830658e77454a0c7dd437c75522a6debf9f64 with parent c724b67, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (8e0830658e77454a0c7dd437c75522a6debf9f64): comparison url.

@jyn514
Copy link
Member

jyn514 commented Jul 15, 2020

Looks like no (or negligible) effect on perf.

@lcnr lcnr closed this Jul 15, 2020
@mati865
Copy link
Contributor

mati865 commented Jul 15, 2020

Wall-time, taks-clock and similar time measuring metrics show massive improvement.

Wonder if it's another case for rust-lang/compiler-team#281 or this PR allowed LLVM to better parallelise the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants