Deny unsafe operations in unsafe functions in libstd/alloc.rs #74333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
poliorcetics
force-pushed
the
std-alloc-unsafe-op-in-unsafe-fn
branch
from
ab28219
to
c38230e
Compare
22 tasks
LukasKalbertodt
approved these changes
Jul 19, 2020
Comment on lines
+340
to
+341
| // SAFETY: see the guarantees expected by `Layout::from_size_align` and | ||
| // `GlobalAlloc::alloc`. |
There was a problem hiding this comment.
But is it documented somewhere that the caller of __rdl_alloc needs to make sure the parameters are valid according to Layout::from_size_align? Same for the functions below.
There was a problem hiding this comment.
Not to my knowledge, or at least I do not remember finding anything when searching for it. I read the code several times to check and saw nothing that invalidated that but I may have missed something.
|
@bors r+ |
|
📌 Commit c38230e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2020
…arth Rollup of 4 pull requests Successful merges: - rust-lang#74333 (Deny unsafe operations in unsafe functions in libstd/alloc.rs) - rust-lang#74356 (Remove combine function) - rust-lang#74419 (Add a thumbv4t-none-eabi target) - rust-lang#74485 (More intra-doc links, add explicit exception list to linkchecker) Failed merges: - rust-lang#74486 (Improve Read::read_exact documentation) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of #73904.
This encloses
unsafeoperations inunsafe fninlibstd/alloc.rs.@rustbot modify labels: F-unsafe-block-in-unsafe-fn