Stabilize intra-doc links #74430

Manishearth · 2020-07-17T07:19:52Z

Thanks to the great work of @jyn514 in getting the cross-crate reexport issue in intra-rustdoc links fixed, I think we're now in a position to stabilize this feature.

The tracking issue currently has two unresolved issues:

behavior around doc(hidden): This is fixed in Record visibility of reexports for all items, not just type items #73365, which is just waiting for CI and should land tomorrow. It's also a pretty niche bug so while I expect it to land soon I don't think we need to block stabilization on it anyway.
Non-identifier primitive types like slices: This was not a part of the original RFC anyway, and is a pretty niche use case

The feature itself, sans #65983, has been shipped on nightly for three years now, with people using it on docs.rs. #65983 itself is not an overwhelmingly central bit of functionality; the reason we elected to block stabilization on it was that back in 2017 it was not possible to fix the issue without some major refactorings of resolve, and we did not want to stabilize something that had such a potentially unfixable bug.

Given that we've fixed it, I see no reason to delay stabilization on this long awaited feature. It's possible that the latest patches have problems, however we have done crater runs of some of the crucial parts. Furthermore, that's what the release trains are for, we will have a solid three months to let it ride the trains before it actually hits the stable compiler.

r? @rust-lang/rustdoc

src/doc/rustdoc/src/linking-to-items-by-name.md

jyn514

Do we need an FCP to stabilize? I know @ollie27 had concerns. We have 6 weeks until the next release so personally I don't mind waiting until #32129 and #32130 are fixed, they should be easy now that cross crate re-exports work :)

jyn514 · 2020-07-17T12:40:10Z

error: unused import: `rustc_feature::UnstableFeatures`
 --> src/librustdoc/passes/collect_intra_doc_links.rs:4:5
  |
4 | use rustc_feature::UnstableFeatures;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`

🎉

Manishearth · 2020-07-17T17:39:28Z

Do we need an FCP to stabilize? I know @ollie27 had concerns. We have 6 weeks until the next release so personally I don't mind waiting until #32129 and #32130 are fixed, they should be easy now that cross crate re-exports work :)

Yes, we do, but note that the FCP itself takes time. ~~I don't think #32129 and #32130 are blockers, they're about using this feature in the stdlib, but if you want to fix them, go ahead!~~ I fixed them: #74453

Manishearth · 2020-07-17T17:51:55Z

Addressed

GuillaumeGomez · 2020-07-17T19:52:59Z

I won't be around for the week-end so if someone wants to open the FCP (better to be @ollie27 I think since they have some remaining issues on their mind), please do so, so we can move forward.

Manishearth · 2020-07-17T19:53:13Z

I fixed the two libstd issues, worked fine! #74453

Manishearth · 2020-07-17T19:53:55Z

@GuillaumeGomez it's the other way around, someone who wants to merge it (e.g. me) should open the FCP, and others can register concerns. I'll do it.

Manishearth · 2020-07-17T19:54:01Z

@rfcbot fcp merge

GuillaumeGomez · 2020-07-17T19:54:48Z

👍

src/doc/rustdoc/src/linking-to-items-by-name.md

GuillaumeGomez · 2020-07-17T20:18:53Z

src/doc/rustdoc/src/linking-to-items-by-name.md

+```rust
+/// This is a special implementation of [positional parameters]
+///
+/// [positional parameters]: std::fmt#formatting-parameters


Maybe add a reminder explaining that before # it's the intra-doc and after it's an anchor in the target page.

I think it's pretty obvious here

It doesn't kill to add explanations and I had to read it twice to figure it out. So I think it totally deserves to have an extra explanation (better too much documentation than not enough 😛 ).

I actually think too much documentation can be a problem where it distracts from the important stuff, and I'd rather not explain how fragment specifiers work here.

In this case, it's just a sentence. And originally, I just used Type#anchor to demonstrate it because using fully qualified path made the example more difficult to understand. I still think that we should add a sentence to explain quickly that after # is the anchor to the target page.

jyn514 · 2020-07-17T20:33:51Z

@rfcbot concern wait for String links to be fixed

@ollie27 mentioned in #43466 (comment) that intra-doc links were originally designed for #32129 and #32130. I think we should wait until those are fixed to decide, which will helps us find lingering issues (e.g. #74458). @Manishearth already has a PR open (#74453) so I don't expect this to take too long, but it will help us understand the tradeoffs better instead of stabilizing all of intra-doc links within 24 hours of cross-crate re-exports being fixed.

Note that I don't think we need to fix all the bugs that pop up, we should just make sure we know what tradeoffs we're making.

jyn514

Diagnostics have improved since this was written :)

src/doc/rustdoc/src/linking-to-items-by-name.md

src/doc/rustdoc/src/lints.md

Co-authored-by: Joshua Nelson <joshua@yottadb.com>

Manishearth · 2020-09-23T22:49:21Z

@rfcbot fcp merge

wonder why it doesn't think the FCP resolved

Manishearth · 2020-09-23T22:52:34Z

@bors r+

I suspect my accidental r+ earlier made rfcbot forget about this somehow. Oh well, it's been a week, going to hit the button.

bors · 2020-09-23T22:52:35Z

📌 Commit 6928041 has been approved by Manishearth

@jyn514

…Manishearth Stabilize intra-doc links Fixes rust-lang#43466 Thanks to the great work of @jyn514 in getting the [cross-crate reexport issue](rust-lang#65983) in intra-rustdoc links fixed, I think we're now in a position to stabilize this feature. The tracking issue currently has two unresolved issues: - <s>behavior around doc(hidden): This is fixed in rust-lang#73365, which is just waiting for CI and should land tomorrow. It's also a pretty niche bug so while I expect it to land soon I don't think we need to block stabilization on it anyway.</s> - Non-identifier primitive types like slices: This was not a part of the original RFC anyway, and is a pretty niche use case The feature itself, sans rust-lang#65983, has been shipped on nightly for three years now, with people using it on docs.rs. rust-lang#65983 itself is not an overwhelmingly central bit of functionality; the reason we elected to block stabilization on it was that back in 2017 it was not possible to fix the issue without some major refactorings of resolve, and we did not want to stabilize something that had such a potentially unfixable bug. Given that we've fixed it, I see no reason to delay stabilization on this long awaited feature. It's possible that the latest patches have problems, however we _have_ done crater runs of some of the crucial parts. Furthermore, that's what the release trains are for, we will have a solid three months to let it ride the trains before it actually hits the stable compiler. r? @rust-lang/rustdoc

rfcbot · 2020-09-24T01:03:10Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

bors · 2020-09-24T03:43:04Z

⌛ Testing commit 6928041 with merge 78a0894...

bors · 2020-09-24T05:57:00Z

☀️ Test successful - checks-actions, checks-azure
Approved by: Manishearth
Pushing 78a0894 to master...

LeSeulArtichaut · 2020-09-24T07:57:02Z

This is awesome! Thanks to everyone who worked on this ❤️

orthecreedence · 2020-09-29T06:18:08Z

Very excited about this! Thanks, team!

Clean up some of the pkgsrc Makefile, there's still lots in here that should just be deleted though. Switch SunOS to the illumos bootstrap by default. Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.][77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

Pkgsrc changes: * Compensate for files being moved around upstream. * Introduce optional, on-by-default semi-static building of cargo, using the internal curl and openssl sources. This reduces the dynamic dependencies of cargo and therefore the rust package itself. Ref. options.mk. * The 1.47.0 bootstrap kits have been re-built with the above option turned on, so no longer depends on curl or openssl from pkgsrc and/or from earlier OS or pkgsrc versions. This should hopefully fix installation of rust with non-default PREFIX, ref. PR#54453. Upstream changes: Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.] [77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2020

Manishearth mentioned this pull request Jul 17, 2020

Tracking issue for RFC 1946 - intra-rustdoc links #43466

Closed

27 tasks

Manishearth added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 17, 2020

GuillaumeGomez reviewed Jul 17, 2020

View reviewed changes

src/doc/rustdoc/src/linking-to-items-by-name.md Outdated Show resolved Hide resolved

jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 17, 2020

jonas-schievink added this to the 1.46 milestone Jul 17, 2020

jyn514 approved these changes Jul 17, 2020

View reviewed changes

Manishearth force-pushed the stabilize-intra-doc branch 2 times, most recently from ad87a2a to 74326bf Compare July 17, 2020 17:50

Manishearth mentioned this pull request Jul 17, 2020

Extend intra-doc links documentation #74436

Closed

This comment has been minimized.

Sign in to view

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 17, 2020

GuillaumeGomez reviewed Jul 17, 2020

View reviewed changes

src/doc/rustdoc/src/linking-to-items-by-name.md Outdated Show resolved Hide resolved

GuillaumeGomez reviewed Jul 17, 2020

View reviewed changes

Manishearth force-pushed the stabilize-intra-doc branch from 0de3781 to 22cfeaa Compare July 17, 2020 21:02

Manishearth closed this Jul 18, 2020

Manishearth deleted the stabilize-intra-doc branch July 18, 2020 01:14

rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 18, 2020

Manishearth restored the stabilize-intra-doc branch July 18, 2020 01:44

jyn514 added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2020

jyn514 reviewed Sep 14, 2020

View reviewed changes

src/doc/rustdoc/src/linking-to-items-by-name.md Outdated Show resolved Hide resolved

src/doc/rustdoc/src/lints.md Outdated Show resolved Hide resolved

Update src/doc/rustdoc/src/lints.md

792b2ea

Co-authored-by: Joshua Nelson <joshua@yottadb.com>

jyn514 mentioned this pull request Sep 17, 2020

Report an ambiguity if both modules and primitives are in scope for intra-doc links #75815

Merged

Update src/doc/rustdoc/src/linking-to-items-by-name.md

6928041

Co-authored-by: Joshua Nelson <joshua@yottadb.com>

str4d mentioned this pull request Sep 19, 2020

Fix lint warnings: "lint intra_doc_link_resolution_failure has been renamed to broken_intra_doc_links" zcash/librustzcash#279

Closed

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 23, 2020

Dylan-DPC-zz mentioned this pull request Sep 24, 2020

Rollup of 12 pull requests #77132

Closed

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 24, 2020

rfcbot added the to-announce Announce this issue on triage meeting label Sep 24, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2020

bors merged commit 78a0894 into rust-lang:master Sep 24, 2020

spastorino removed the to-announce Announce this issue on triage meeting label Sep 24, 2020

Juici mentioned this pull request Oct 11, 2020

Support for intra_docs links intellij-rust/intellij-rust#4845

Open

hannobraun mentioned this pull request Oct 19, 2020

Check documentation for broken links hannobraun/stepper#1

Closed

mgeisler mentioned this pull request Nov 8, 2020

Use automatic intra-doc links mgeisler/textwrap#222

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize intra-doc links #74430

Stabilize intra-doc links #74430

Manishearth commented Jul 17, 2020 •

edited

Loading

jyn514 left a comment

jyn514 commented Jul 17, 2020

Manishearth commented Jul 17, 2020 •

edited

Loading

Manishearth commented Jul 17, 2020

GuillaumeGomez commented Jul 17, 2020

Manishearth commented Jul 17, 2020

Manishearth commented Jul 17, 2020

Manishearth commented Jul 17, 2020

This comment has been minimized.

GuillaumeGomez commented Jul 17, 2020

GuillaumeGomez Jul 17, 2020

Manishearth Jul 17, 2020

GuillaumeGomez Jul 20, 2020

Manishearth Jul 20, 2020

GuillaumeGomez Jul 20, 2020

jyn514 commented Jul 17, 2020

jyn514 left a comment

Manishearth commented Sep 23, 2020

Manishearth commented Sep 23, 2020

bors commented Sep 23, 2020

rfcbot commented Sep 24, 2020

bors commented Sep 24, 2020

bors commented Sep 24, 2020

LeSeulArtichaut commented Sep 24, 2020

orthecreedence commented Sep 29, 2020

Stabilize intra-doc links #74430

Stabilize intra-doc links #74430

Conversation

Manishearth commented Jul 17, 2020 • edited Loading

jyn514 left a comment

Choose a reason for hiding this comment

jyn514 commented Jul 17, 2020

Manishearth commented Jul 17, 2020 • edited Loading

Manishearth commented Jul 17, 2020

GuillaumeGomez commented Jul 17, 2020

Manishearth commented Jul 17, 2020

Manishearth commented Jul 17, 2020

Manishearth commented Jul 17, 2020

This comment has been minimized.

GuillaumeGomez commented Jul 17, 2020

GuillaumeGomez Jul 17, 2020

Choose a reason for hiding this comment

Manishearth Jul 17, 2020

Choose a reason for hiding this comment

GuillaumeGomez Jul 20, 2020

Choose a reason for hiding this comment

Manishearth Jul 20, 2020

Choose a reason for hiding this comment

GuillaumeGomez Jul 20, 2020

Choose a reason for hiding this comment

jyn514 commented Jul 17, 2020

jyn514 left a comment

Choose a reason for hiding this comment

Manishearth commented Sep 23, 2020

Manishearth commented Sep 23, 2020

bors commented Sep 23, 2020

rfcbot commented Sep 24, 2020

bors commented Sep 24, 2020

bors commented Sep 24, 2020

LeSeulArtichaut commented Sep 24, 2020

orthecreedence commented Sep 29, 2020

Manishearth commented Jul 17, 2020 •

edited

Loading

Manishearth commented Jul 17, 2020 •

edited

Loading