Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn about uninitialized multi-variant enums (invalid_value lint) #74438

Merged
merged 1 commit into from
Jul 18, 2020
Merged

warn about uninitialized multi-variant enums (invalid_value lint) #74438

merged 1 commit into from
Jul 18, 2020

Conversation

RalfJung
Copy link
Member

Fixes #73608

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2020
lcnr
lcnr reviewed Jul 17, 2020
View reviewed changes
src/librustc_lint/builtin.rs Outdated Show resolved Hide resolved
lcnr
lcnr reviewed Jul 17, 2020
View reviewed changes
src/librustc_lint/builtin.rs Outdated Show resolved Hide resolved
lcnr
lcnr reviewed Jul 17, 2020
View reviewed changes
src/librustc_lint/builtin.rs Outdated Show resolved Hide resolved
davidtwco
davidtwco approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me after other comments resolved.

@RalfJung
Copy link
Member Author

oops so many typos...

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jul 17, 2020

📌 Commit aba35fcd5921f5d6608d6890d1fd752486cf7734 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2020
@davidtwco
Copy link
Member

@RalfJung if it isn't too much trouble, could you squash those last two commits?

@RalfJung
Copy link
Member Author

@bors r-
@davidtwco Sure. do you mean squash them into one (so there are 2 commits overall), or squash them both into the first (so there is one commit overall)?

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2020
@davidtwco
Copy link
Member

@bors r-
@davidtwco Sure. do you mean squash them into one (so there are 2 commits overall), or squash them both into the first (so there is one commit overall)?

Squash both into the first commit.

@RalfJung
Copy link
Member Author

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jul 17, 2020

📌 Commit 87b4976 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2020
@Manishearth Manishearth mentioned this pull request Jul 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2020
@bors
Auto merge of rust-lang#74461 - Manishearth:rollup-xadbh00, r=Manishe…
d3df851 
…arth

Rollup of 18 pull requests

Successful merges:

 - rust-lang#71670 (Enforce even more the code blocks attributes check through rustdoc)
 - rust-lang#73930 (Make some Option methods const)
 - rust-lang#74009 (Fix MinGW `run-make-fulldeps` tests)
 - rust-lang#74056 (Add Arguments::as_str().)
 - rust-lang#74169 (Stop processing unreachable blocks when solving dataflow)
 - rust-lang#74251 (Teach bootstrap about target files vs target triples)
 - rust-lang#74288 (Fix src/test/run-make/static-pie/test-aslr.rs)
 - rust-lang#74300 (Use intra-doc links in core::iter module)
 - rust-lang#74364 (add lazy normalization regression tests)
 - rust-lang#74368 (Add CSS tidy check)
 - rust-lang#74394 (Remove leftover from emscripten fastcomp support)
 - rust-lang#74411 (Don't assign `()` to `!` MIR locals)
 - rust-lang#74416 (Use an UTF-8 locale for the linker.)
 - rust-lang#74424 (Move hir::Place to librustc_middle/hir)
 - rust-lang#74428 (docs: better demonstrate that None values are skipped as many times a…)
 - rust-lang#74438 (warn about uninitialized multi-variant enums)
 - rust-lang#74440 (Fix Arc::as_ptr docs)
 - rust-lang#74452 (intra-doc links: resolve modules in the type namespace)

Failed merges:

r? @ghost
@bors bors merged commit cdedae8 into rust-lang:master Jul 18, 2020
@RalfJung RalfJung deleted the uninit-lint branch July 20, 2020 12:37
@RalfJung RalfJung changed the title warn about uninitialized multi-variant enums warn about uninitialized multi-variant enums (invalid_value lint) Aug 31, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

@lcnr lcnr lcnr approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

"incorrect use of uninit memory" lint should fire for multi-variant enum
6 participants
@RalfJung @rust-highfive @bors @davidtwco @lcnr @cuviper