Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize TAU constant. #74552

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Stabilize TAU constant. #74552

merged 1 commit into from
Jul 21, 2020

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jul 20, 2020

Closes #66770.

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2020
@m-ou-se
Copy link
Member Author

m-ou-se commented Jul 20, 2020

Did I pick the right version? (1.47)

@jonas-schievink jonas-schievink added this to the 1.47 milestone Jul 20, 2020
@jonas-schievink jonas-schievink added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 20, 2020
@dtolnay
Copy link
Member

dtolnay commented Jul 20, 2020

Relabeling libs-impl because the libs team FCP had already completed in #66770 (comment) so a stabilization PR does not require libs team review.

@rustbot modify labels: -T-libs and +libs-impl

@rustbot rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 20, 2020
@dtolnay
Copy link
Member

dtolnay commented Jul 20, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2020

📌 Commit 5d4147a has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020
@Manishearth Manishearth mentioned this pull request Jul 20, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2020
@bors
Auto merge of rust-lang#74569 - Manishearth:rollup-hkn5ex9, r=Manishe…
734233d 
…arth

Rollup of 13 pull requests

Successful merges:

 - rust-lang#72714 (Fix debug assertion in typeck)
 - rust-lang#73197 (Impl Default for ranges)
 - rust-lang#73323 (wf: check foreign fn decls for well-formedness)
 - rust-lang#74051 (disallow non-static lifetimes in const generics)
 - rust-lang#74376 (test caching opt_const_param_of on disc)
 - rust-lang#74501 (Ayu theme: Use different background color for Run button)
 - rust-lang#74505 (Fix search input focus in ayu theme)
 - rust-lang#74522 (Update sanitizer docs)
 - rust-lang#74546 (Fix duplicate maybe_uninit_extra attribute)
 - rust-lang#74552 (Stabilize TAU constant.)
 - rust-lang#74555 (Improve "important traits" popup display on mobile)
 - rust-lang#74557 (Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern)
 - rust-lang#74561 (update backtrace-rs)

Failed merges:

r? @ghost
@bors bors merged commit 810d322 into rust-lang:master Jul 21, 2020
@m-ou-se m-ou-se deleted the stabilize-tau branch July 21, 2020 07:59
@unageek unageek mentioned this pull request Aug 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Tracking issue for core::{f32,f64}::consts::TAU
6 participants
@m-ou-se @rust-highfive @dtolnay @bors @jonas-schievink @rustbot