-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an ICE on an invalid binding @ ...
in a tuple struct pattern
#74557
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
enum E { | ||
A(u8, u8), | ||
} | ||
|
||
fn main() { | ||
let e = E::A(2, 3); | ||
match e { | ||
E::A(x @ ..) => { //~ ERROR `x @` is not allowed in a tuple | ||
x //~ ERROR cannot find value `x` in this scope | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JohnTitor, this is a consequence of the nature of the fix. But I think you're right, this should be done differently. |
||
} | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
error[E0425]: cannot find value `x` in this scope | ||
--> $DIR/issue-74539.rs:9:13 | ||
| | ||
LL | x | ||
| ^ help: a local variable with a similar name exists: `e` | ||
|
||
error: `x @` is not allowed in a tuple struct | ||
--> $DIR/issue-74539.rs:8:14 | ||
| | ||
LL | E::A(x @ ..) => { | ||
| ^^^^^^ this is only allowed in slice patterns | ||
| | ||
= help: remove this and bind each tuple field independently | ||
help: if you don't need to use the contents of x, discard the tuple's remaining fields | ||
| | ||
LL | E::A(..) => { | ||
| ^^ | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0425`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can be merged as is, but I think we could also add another branch that detects the case with
PatKind::Ident(..)
where..
is present and record it with aPartialRes::new(Res::Err)
, which should eliminate the second unnecessary error that complains aboutx
not being defined. (Haven't looked at this deeply enough to be sure.)