Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] perf-test for #74021 #74660

Closed
wants to merge 2 commits into from

Conversation

rust-timer
Copy link
Collaborator

This is an automatically generated pull request (from here) to run perf tests for #74021 which merged in a rollup.

r? @ghost

Original message:
Rollup merge of rust-lang#74021 - 1011X:master, r=dtolnay

impl Index<RangeFrom> for CStr

This change implements (partial) slicing for `CStr`.

Since a `CStr` must end in a null byte, it's not possible to trim from the right and still have a valid `CStr`. But, it *is* possible to trim from the left. This lets us be a bit more flexible and treat them more like strings.

```rust
let string = CStr::from_bytes_with_nul(b"Hello World!\0");
let result = CStr::from_bytes_with_nul(b"World!\0");
assert_eq!(&string[6..], result);
```
@rust-timer
Copy link
Collaborator Author

@bors try @rust-timer queue

The try commit's (master) parent should be bbebe73. If it isn't, then please:

  • Stop this try build (try-).
  • Run @rust-timer update-pr-for f305b200df5af87608677f30c272f47cf2210623.
  • Rerun bors try.

You do not need to reinvoke the queue command as long as the perf build hasn't yet started.

@rust-timer
Copy link
Collaborator Author

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jul 22, 2020

⌛ Trying commit 430994c with merge 02251f9938d32bc9b813c225de60bd769bcdf88c...

@bors
Copy link
Contributor

bors commented Jul 23, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 02251f9938d32bc9b813c225de60bd769bcdf88c (02251f9938d32bc9b813c225de60bd769bcdf88c)

@rust-timer
Copy link
Collaborator Author

Queued 02251f9938d32bc9b813c225de60bd769bcdf88c with parent bbebe73, future comparison URL.

@Mark-Simulacrum
Copy link
Member

@rust-timer
Copy link
Collaborator Author

Finished benchmarking try commit (02251f9938d32bc9b813c225de60bd769bcdf88c): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Mark-Simulacrum
Copy link
Member

Seems like it wasn't this either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants