Miri: replace canonical_alloc_id mechanism by extern_static_alloc_id #74775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which is called only when a pointer is 'imported' into the machine
|
This side lgtm. I think the miri side should work before r+ing this side though, so we don't produce a broken miri that needs a rustc fix to work. |
|
The Miri side is up at rust-lang/miri#1489. No further rustc changes were required, but I decided to also perform a rename that I had suggested in #71194. @oli-obk does that rename seem sensible? |
|
Jup, both sides and the rename are good with me @bors r+ |
|
📌 Commit b8fd0f6 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jul 27, 2020
Adjust for new rustc alloc ID handling and deallocate thread-local statics Miri side of rust-lang/rust#74775. Fixes #1369 Fixes #1488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only have to call
extern_static_alloc_idwhen aPointeris "imported" from thetcxto the machine, not on each access. Also drop the old hook for TLS handling, it is not needed any more.The Miri side of this is at rust-lang/miri#1489.
Fixes #71194
r? @oli-obk